Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK11 support #3601

Merged
merged 42 commits into from Feb 12, 2020
Merged

JDK11 support #3601

merged 42 commits into from Feb 12, 2020

Conversation

rohityadavcloud
Copy link
Member

@rohityadavcloud rohityadavcloud commented Sep 18, 2019

This splits the Debian10 base/template changes to this PR #3797

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@wido
Copy link
Contributor

wido commented Sep 18, 2019

This is a good start!

In #3195 @GabrielBrascher and me are working on porting scripts to Python 3.

Inside the SSVM we have a lot of Python 2 code which needs to be looked at.

Debian 10 still has Python 2, but the next Debian release won't have it anymore.

@apache apache deleted a comment from blueorangutan Nov 19, 2019
@apache apache deleted a comment from blueorangutan Nov 19, 2019
@apache apache deleted a comment from blueorangutan Nov 19, 2019
@apache apache deleted a comment from blueorangutan Nov 19, 2019
@apache apache deleted a comment from blueorangutan Nov 19, 2019
@apache apache deleted a comment from blueorangutan Nov 19, 2019
@rohityadavcloud rohityadavcloud deleted the jdk11-support branch February 8, 2020 09:29
@rohityadavcloud rohityadavcloud restored the jdk11-support branch February 8, 2020 09:29
@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@rohityadavcloud
Copy link
Member Author

Manually rekicked packaging

@blueorangutan
Copy link

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-794

@weizhouapache
Copy link
Member

@rhtyd have you build new systemvm template with jdk11 ?

@rohityadavcloud
Copy link
Member Author

@weizhouapache
Copy link
Member

@weizhouapache http://download.cloudstack.org/systemvm/4.14/

@rhtyd thanks.
my mistake, I re-upload new systemvm template but did not clean template_spool_ref so systemvms still use old 4.11.3 template.
I will test it.

@blueorangutan
Copy link

Trillian test result (tid-940)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t940-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 78 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 223.32 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 222.00 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 320.87 test_privategw_acl.py

@rohityadavcloud
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-798

@blueorangutan
Copy link

Trillian test result (tid-941)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35935 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t941-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 73 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 333.01 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 338.23 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 520.67 test_privategw_acl.py

@rohityadavcloud
Copy link
Member Author

VP failures are consistently failing on few others PRs.

The following tests on Travis are consistently failing:

| test_03_delete_detached_volume | Failure | 90.193 | test_volumes |
| test_11_destroy_vm_and_volumes | Failure | 46.104 | test_vm_life_cycle |
| test_09_delete_detached_volume | Failure | 5.401  | test_volumes    

@weizhouapache can you check ^^ and advise? This is also seen on master. cc @DaanHoogland @andrijapanicsb

@weizhouapache
Copy link
Member

@rhtyd @DaanHoogland I will check
Do we have same issue on other PRs ?

@rohityadavcloud
Copy link
Member Author

Possibly @weizhouapache, the test failures hint at the recently merged feature perhaps. Can you check?

@blueorangutan
Copy link

Trillian test result (tid-944)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31118 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t944-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 78 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 215.17 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 211.53 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 315.04 test_privategw_acl.py

@blueorangutan
Copy link

Trillian test result (tid-945)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45861 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t945-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 77 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_vpc_privategw_static_routes Failure 355.77 test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 348.59 test_privategw_acl.py
test_04_rvpc_privategw_static_routes Failure 555.38 test_privategw_acl.py
test_01_scale_vm Failure 19.60 test_scale_vm.py

@rohityadavcloud
Copy link
Member Author

Smoketests LGTM, except for test_privategw_acl.py failures which are known. Travis LGTM except for the failures shared, I'll collaborate with @weizhouapache to get it addressed via #3880

@rohityadavcloud
Copy link
Member Author

Considering no objections and lgtm from Andrija and Daan will merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants