From 425ac2890e93517ee77f47608e901c5f7a227999 Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Sun, 7 Jun 2015 21:33:49 +0200 Subject: [PATCH] Fix 3 more findbugs performance alerts, creating Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource --- .../f5/src/com/cloud/network/resource/F5BigIpResource.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java b/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java index 0f70a9b51392..c4e0fdfb4c1b 100644 --- a/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java +++ b/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java @@ -294,7 +294,7 @@ private synchronized Answer execute(IpAssocCommand cmd, int numRetries) { for (IpAddressTO ip : ips) { // is it saver to use Long.valueOf(BroadcastDomain.getValue(ip.getBroadcastUri())) ??? // i.o.w. can this contain vlan:// then change !!! - long guestVlanTag = Long.valueOf(ip.getBroadcastUri()); + long guestVlanTag = Long.parseLong(ip.getBroadcastUri()); // It's a hack, using isOneToOneNat field for indicate if it's inline or not boolean inline = ip.isOneToOneNat(); String vlanSelfIp = inline ? tagAddressWithRouteDomain(ip.getVlanGateway(), guestVlanTag) : ip.getVlanGateway(); @@ -700,7 +700,7 @@ private void deleteVirtualServerAndDefaultPool(String virtualServerName) throws List poolMembers = getMembers(virtualServerName); for (String poolMember : poolMembers) { String[] destIpAndPort = getIpAndPort(poolMember); - deletePoolMember(virtualServerName, destIpAndPort[0], Integer.valueOf(destIpAndPort[1])); + deletePoolMember(virtualServerName, destIpAndPort[0], Integer.parseInt(destIpAndPort[1])); } // Delete the virtual server @@ -886,7 +886,7 @@ private void deleteInactivePoolMembers(String virtualServerName, List ac for (String member : allPoolMembers) { if (!activePoolMembers.contains(member)) { String[] ipAndPort = member.split("-"); - deletePoolMember(virtualServerName, ipAndPort[0], Integer.valueOf(ipAndPort[1])); + deletePoolMember(virtualServerName, ipAndPort[0], Integer.parseInt(ipAndPort[1])); } } }