New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display nics deviceid and order nics by deviceid on Nics tab of insta… #4768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 55 |
[S] Trillian test result (tid-58)
|
none of these ^^ errors have to do with this PR afaics. |
@soreana this looks like a good enhancement. @DaanHoogland @shwstppr should we consider/ask for 4.15.1? |
@DaanHoogland let's merge it to 4.16. |
+1 I didn't look at code changes, if it involved db changes.
…On Fri, 12 Mar, 2021, 4:27 pm Wei Zhou, ***@***.***> wrote:
@rhtyd <https://github.com/rhtyd> (cc @soreana
<https://github.com/soreana> ) though it is a minor change it does
include AI and DB changes, so I'd say leave it for 4.16 (that is not a
definite 👎 at all, just a expression of our merge principles and
principles are there to be broken with)
@DaanHoogland <https://github.com/DaanHoogland> let's merge it to 4.16.
as far as I know, 4.15 accepts only bug fixes and security fixes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4768 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXHYZO6TTUCMP73ZM5SP3TDHXRPANCNFSM4YY5UL6Q>
.
|
@soreana can you fix the conflicts |
@rhtyd Done :) |
@blueorangutan package |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 575 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
@rhtyd are we still considdering this for 4.15? |
@DaanHoogland from what I read, apart from me nobody was interested in 4.15 including the author so I didn't push it any further. I just checked branch compatibility and it looks like without rebasing (+ moving any db changes to the right file) this causes conflicts on 4.15. I'm fine with what others have said. Also see your #4768 (comment) |
@soreana can you fix the conflict? Thanks. |
Hi @soreana can you please fix the conflict? |
1 similar comment
Hi @soreana can you please fix the conflict? |
I fixed the conflict. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 535 |
@blueorangutan test |
Trillian test result (tid-1255)
|
@blueorangutan test |
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1277)
|
@blueorangutan package |
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 581 |
@blueorangutan test |
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1310)
|
@blueorangutan package |
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 657 |
@blueorangutan test |
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1383)
|
@blueorangutan test |
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Trillian test result (tid-1390)
|
Description
As a cloudstack team, we want to show sorted NICs in the Nic tab of the instance and API calls. To achieve this goal, cloudstack should put the deviceid in userVmResponse. This is the minor PR to add this feature.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
I deployed the following instance in my test environment with three networks, as you can see they are sorted in NIC tab.