Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: vmware vm import-unmanage #5075

Merged
merged 18 commits into from Jul 27, 2021
Merged

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jun 4, 2021

Description

Adds UI for importing and unmanaging VMs.
A new navigation section - Tools has been added in the UI.

Doc PR: apache/cloudstack-documentation#221

import-unmanage-instances

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot 2021-06-18 at 13-20-03 Import-Export Instances - CloudStack

Screenshot 2021-06-18 at 13-17-07 Import-Export Instances - CloudStack

Screenshot 2021-06-18 at 13-18-26 Import-Export Instances - CloudStack

How Has This Been Tested?

@apache apache deleted a comment from blueorangutan Jun 15, 2021
@apache apache deleted a comment from blueorangutan Jun 15, 2021
Add UI for importing and unmanaging VMs for a VMware cluster

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr changed the title ui: vmware vm ingestion ui: vmware vm import-unmanage Jun 17, 2021
@apache apache deleted a comment from blueorangutan Jun 17, 2021
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 263

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, basic checks, licenses in the new files and overall code. UI changes needs manual testing.

@rohityadavcloud rohityadavcloud added this to the 4.16.0.0 milestone Jun 17, 2021
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 265

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI Code LGTM! Can't test in my environment.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 286

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 5, 2021

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 472

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, based on manual verification

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Jul 7, 2021

Last commit unrelated to import wizard/form. A change in UI component was causing some fields not visible in AddNetworkOffering form. Fixed now.

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5075 (SL-JID-328)

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 498

@shwstppr shwstppr marked this pull request as ready for review July 15, 2021 07:43
@shwstppr shwstppr marked this pull request as draft July 15, 2021 07:47
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

Last commit added to use UI component added with 041948c

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5075 (SL-JID-363)

@andrijapanicsb
Copy link
Contributor

@blueorangutan ui

Last commit added to use UI component added with 041948c

This doesn't explain much what was changed (to me at least) and it comes after LGTM from Boris (and the internal review from me) @shwstppr . Also some conflicts are there. thx

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✖️
(SL-JID-374)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@andrijapanicsb Fixed conflicts
Commit in question b3e2ace changed the tooltip code for form items.
Screenshot from 2021-07-19 12-23-02
Before 041948c (#5133), above icon was shown with code,

<span slot="label">
  {{ $t('label.displayname') }}
  <a-tooltip :title="apiParams.displayname.description">
    <a-icon type="info-circle" style="color: rgba(0,0,0,.45)" />
  </a-tooltip>
</span>

With PR #5133, new Vue component (TooltipLabel.vue) was added which allowed above code to be refactored as,

<tooltip-label slot="label" :title="$t('label.displayname')" :tooltip="apiParams.displayname.description"/>

PR #5133 was merged into main after your review.

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5075 (SL-JID-379)

@rohityadavcloud rohityadavcloud marked this pull request as ready for review July 27, 2021 05:42
@rohityadavcloud rohityadavcloud merged commit 87ee866 into apache:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants