New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: vmware vm import-unmanage #5075
Conversation
Add UI for importing and unmanaging VMs for a VMware cluster Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
1dba6f2
to
0ff2e96
Compare
@blueorangutan package |
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 263 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, basic checks, licenses in the new files and overall code. UI changes needs manual testing.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@blueorangutan package |
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 265 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI Code LGTM! Can't test in my environment.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 286 |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@blueorangutan package |
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 472 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, based on manual verification
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Last commit unrelated to import wizard/form. A change in UI component was causing some fields not visible in AddNetworkOffering form. Fixed now. |
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 498 |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Last commit added to use UI component added with 041948c |
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@andrijapanicsb a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✖️ |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@andrijapanicsb Fixed conflicts
With PR #5133, new Vue component (TooltipLabel.vue) was added which allowed above code to be refactored as,
PR #5133 was merged into |
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
Description
Adds UI for importing and unmanaging VMs.
A new navigation section - Tools has been added in the UI.
Doc PR: apache/cloudstack-documentation#221
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?