Check the pool used space from the bytes used in the storage pool stats collector, for non-default primary storage pools that cannot provide stats. #5586
Conversation
…ts collector, for non-default primary storage pools that cannot provide stats. Also, Update the used bytes from the pool stats answer for non-default primary storage pools if the pool can provide stats.
|
@blueorangutan package |
1 similar comment
|
@blueorangutan package |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1593 |
|
@blueorangutan test matrix |
|
@sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests |
|
Trillian test result (tid-2450) |
|
Trillian test result (tid-2449) |
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
| @Override | ||
| public boolean canPoolProvideStorageStats(StoragePool pool) { | ||
| DataStoreProvider storeProvider = _dataStoreProviderMgr.getDataStoreProvider(pool.getStorageProviderName()); | ||
| DataStoreDriver storeDriver = storeProvider.getDataStoreDriver(); |
There was a problem hiding this comment.
@sureshanaparti do we need to do any defensive/null checks?
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1599 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1602 |
|
@blueorangutan test |
|
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-2459)
|
|
Ping @borisstoyanov @vladimirpetrov are you lgtm on it? |
Description
This PR checks the pool used space from the bytes used in the storage pool stats collector, for non-default primary storage pools that cannot provide stats. It also update the used bytes from the pool stats answer for non-default primary storage pools if the pool can provide stats.
The PR #4360 updates the used bytes in the database for default primary storage pools only through the stats collector, and computes storage pool space usage from that database value instead of in-memory stats (from the stats collector). So, the storage pool space for non-default primary storage pools is computed against the used bytes in the database which is not updated from the stats collector, and computing with in-memory stats is also removed. This PR keeps the pool used space computation as before (using the in-memory stats from the stats collector), for the non-default primary storage pools.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Manually tested using PowerFlex/ScaleIO storage.