New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: reapply checkVmProfileAndHost to check guest os preference #6000
Conversation
@blueorangutan package |
@GabrielBrascher @sureshanaparti please have a look |
@blueorangutan package |
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2636 |
@blueorangutan test |
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
@sureshanaparti please advise if this can be included on 4.16.1 or should be on 4.17 |
I think, we should include if it is a regression or breaking any previous functionality. |
Trillian test result (tid-3370)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @weizhouapache, LGTM.
Removing these lines should not bring regressions in the context of #3600.
I believe this was caused by either a backporting between different branches or a conflict with the main branch that was not properly addressed by me. These lines slipped by mistake into #3600.
Description
This PR reapply #4338, which is reverted by #3600
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?