Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: reapply checkVmProfileAndHost to check guest os preference #6000

Merged
merged 1 commit into from Feb 17, 2022

Conversation

weizhouapache
Copy link
Member

Description

This PR reapply #4338, which is reverted by #3600

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@DaanHoogland
Copy link
Contributor

@GabrielBrascher @sureshanaparti please have a look

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2636

@sureshanaparti
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez
Copy link
Contributor

@sureshanaparti please advise if this can be included on 4.16.1 or should be on 4.17

@sureshanaparti
Copy link
Contributor

@sureshanaparti please advise if this can be included on 4.16.1 or should be on 4.17

I think, we should include if it is a regression or breaking any previous functionality.

@blueorangutan
Copy link

Trillian test result (tid-3370)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30926 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6000-t3370-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @weizhouapache, LGTM.
Removing these lines should not bring regressions in the context of #3600.

I believe this was caused by either a backporting between different branches or a conflict with the main branch that was not properly addressed by me. These lines slipped by mistake into #3600.

@sureshanaparti sureshanaparti merged commit c543f5f into apache:4.16 Feb 17, 2022
@weizhouapache weizhouapache deleted the 4.16-reapply-4338 branch December 9, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants