From f973d89602c5386f2f00659ebb49432194f303d6 Mon Sep 17 00:00:00 2001 From: Maneesha P Date: Thu, 23 Jul 2015 00:45:00 +0530 Subject: [PATCH] Fixed Coverity issue "Dereference null return value" by adding a Null Value Exception --- .../wrapper/LibvirtBackupSnapshotCommandWrapper.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java index 25da0468dea0..ad33945498a5 100644 --- a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java +++ b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtBackupSnapshotCommandWrapper.java @@ -171,7 +171,11 @@ public Answer execute(final BackupSnapshotCommand command, final LibvirtComputin final String snapshot = snapshotXML.format(args); s_logger.debug(snapshot); final DomainSnapshot snap = vm.snapshotLookupByName(snapshotName); - snap.delete(0); + if (snap != null) { + snap.delete(0); + } else { + throw new CloudRuntimeException("Unable to find vm snapshot with name -" + snapshotName); + } /* * libvirt on RHEL6 doesn't handle resume event emitted from @@ -203,4 +207,4 @@ public Answer execute(final BackupSnapshotCommand command, final LibvirtComputin } return new BackupSnapshotAnswer(command, true, null, snapshotRelPath + File.separator + snapshotName, true); } -} \ No newline at end of file +}