get rid of useless out-of-band alerts #694
Conversation
These alerts are generating a lot of false positives. Try spinning a new router, or migrate one using the API (not out-of-band) and you'll get alerts anyway. I just remove the alert below. We might consider ditching the functionality completely, as route VMs in master are designed to be persistent anyway. Let's at least remove the alerts.
|
I'd rather see some stricter selection on what is alerted then removal of the alerts altogether. |
|
@remibergsma As per discussion in dev list, based on the persistent VR changes, reboot/alert is no longer required in case of out of band VR migration. So the entire code should be removed. |
|
cloudstack-pull-rats #298 SUCCESS |
|
@koushik-das Check. Can you please help doing that? |
|
cloudstack-pull-requests #994 SUCCESS |
|
@remibergsma In the middle of another thing, can help with it possibly by next week. Let me know if that is ok? Basically all code in postStateTransitionEvent() needs to be removed. |
|
@koushik-das Sure, this is not urgent. We'll have a look next week :-) Closing this PR. |
|
cloudstack-pull-analysis #230 ABORTED |
4 participants
These alerts are generating a lot of false positives. Try spinning
a new router, or migrate one using the API (not out-of-band) and
you'll get alerts anyway.
I just removed the alert below. We might consider ditching the
functionality completely, as route VMs in master are designed
to be persistent anyway.
Let's at least remove the alerts.
@dahn @snuf & others, what do you think?