Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More startup logging on Windows in javajni.c. #14

Merged
merged 2 commits into from Dec 12, 2019

Conversation

@garydgregory
Copy link
Member

garydgregory commented Nov 25, 2019

@markt-asf May you please review.

Gary Gregory
@kinow
kinow approved these changes Nov 26, 2019
Copy link
Member

kinow left a comment

Don't know much about daemon, but change looks sensible. Mainly adding more logging, and also some fallback when executables are not found in the path. Only nit-pick are the tabs vs. spaces, though not familiar with code base to say whether it's OK or not. 👍

crtBinPath);
}
apxLogWrite(APXLOG_MARK_DEBUG "Preloaded '%S'", crtBinPath);
}

This comment has been minimized.

Copy link
@kinow

kinow Nov 26, 2019

Member

Tabs here instead of spaces? There are more tabs in this change.

This comment has been minimized.

Copy link
@garydgregory

garydgregory Nov 27, 2019

Author Member

Dang, sorry about that. Fixed.

Gary Gregory
@garydgregory garydgregory merged commit 2b457fd into apache:master Dec 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garydgregory garydgregory changed the title More startup logging. More startup logging in javajni.c. Dec 12, 2019
@garydgregory garydgregory changed the title More startup logging in javajni.c. More startup logging on Windows in javajni.c. Dec 12, 2019
asfgit pushed a commit that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.