Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageHtmlEmailTest.java bug fixed #1

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@simonajj14
Copy link

commented Jun 8, 2016

The only change is on line number 101.

FROM "assertTrue(mimeMessageParser.getAttachmentList().size() == 3);"
TO "assertTrue(mimeMessageParser.getAttachmentList().size() == 1);"

@atodorov

This comment has been minimized.

Copy link

commented Jun 8, 2016

You need a better commit message and also change the line which needs changing, not 1000 more. Maybe these come from new line characters difference between Linux/Windows. See https://help.github.com/articles/dealing-with-line-endings/

The amend your commit and force push again.

@atodorov

This comment has been minimized.

Copy link

commented Jun 8, 2016

Guys, git log for this test reveals it's been changed in a similar fashion sometime ago. Did something change in the mean time? I'm wondering what happened for this failure to persist so long.

@asfgit asfgit closed this in 63db6be Jul 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.