ImageHtmlEmailTest.java bug fixed #1

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@simonajj14
simonajj14 commented Jun 8, 2016 edited

The only change is on line number 101.

FROM "assertTrue(mimeMessageParser.getAttachmentList().size() == 3);"
TO "assertTrue(mimeMessageParser.getAttachmentList().size() == 1);"

@atodorov
atodorov commented Jun 8, 2016

You need a better commit message and also change the line which needs changing, not 1000 more. Maybe these come from new line characters difference between Linux/Windows. See https://help.github.com/articles/dealing-with-line-endings/

The amend your commit and force push again.

@atodorov
atodorov commented Jun 8, 2016

Guys, git log for this test reveals it's been changed in a similar fashion sometime ago. Did something change in the mean time? I'm wondering what happened for this failure to persist so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment