Skip to content
Permalink
Browse files
FILEUPLOAD-340 Make commons-fileupload a proper JPMS module (#107)
* FILEUPLOAD-340 Make commons-fileupload a proper JPMS module

Use moditect-maven-plugin to add auto-generated module-info.class into META-INF/versions/9/

IMPORTANT: Now the build requires JDK 9+! The produced jar is JDK 1.8 compatible!

* FILEUPLOAD-340 Do not export the .impl package
  • Loading branch information
martin-g committed Aug 19, 2021
1 parent 9024c19 commit b6a25b55bb73240bd991b246484325374061dc2e
Showing 2 changed files with 41 additions and 0 deletions.
40 pom.xml
@@ -196,6 +196,10 @@
<name>Arturo Bernal</name>
<email>arturobernalg@gmail.com</email>
</contributor>
<contributor>
<name>Martin Grigorov</name>
<email>mgrigorov@apache.org</email>
</contributor>
</contributors>

<scm>
@@ -233,6 +237,8 @@
<commons.osgi.dynamicImport>javax.portlet</commons.osgi.dynamicImport>
<commons.japicmp.version>0.15.3</commons.japicmp.version>
<japicmp.skip>true</japicmp.skip>
<moditect-maven-plugin.version>1.0.0.RC1</moditect-maven-plugin.version>
<moditect.skip>true</moditect.skip>

<!-- Commons Release Plugin -->
<commons.bc.version>1.3.3</commons.bc.version>
@@ -309,6 +315,34 @@
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.moditect</groupId>
<artifactId>moditect-maven-plugin</artifactId>
<version>${moditect-maven-plugin.version}</version>
<executions>
<execution>
<id>add-module-infos</id>
<phase>package</phase>
<goals>
<goal>add-module-info</goal>
</goals>
<configuration>
<jvmVersion>9</jvmVersion>
<outputDirectory>${project.build.directory}</outputDirectory>
<overwriteExistingFiles>true</overwriteExistingFiles>
<module>
<moduleInfo>
<name>commons.fileupload2</name>
<exports>
!org.apache.commons.fileupload2.impl;
*;
</exports>
</moduleInfo>
</module>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
<pluginManagement>
<plugins>
@@ -555,5 +589,11 @@
<coveralls.skip>true</coveralls.skip>
</properties>
</profile>
<profile>
<id>release</id>
<properties>
<moditect.skip>false</moditect.skip>
</properties>
</profile>
</profiles>
</project>
@@ -58,6 +58,7 @@ The <action> type attribute can be add,update,fix,remove.
<action dev="ggregory" type="update" due-to="Gary Gregory">Update commons.japicmp.version 0.13.0 -> 0.15.3.</action>
<action dev="ggregory" type="update" due-to="Gary Gregory">Bump build actions/setup-java from v1.4.3 to v2.</action>
<action dev="ggregory" type="update" due-to="Dependabot">Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0 #103.</action>
<action dev="mgrigorov" type="update">FILEUPLOAD-340 Make commons-fileupload2 a JPMS module by adding module-info.class.</action>
</release>
<release version="1.4" date="2018-12-23" description="1.4 Release">
<action issue="FILEUPLOAD-292" dev="chtompki" type="update">Don't create un-needed resources in FileUploadBase.java</action>

0 comments on commit b6a25b5

Please sign in to comment.