Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @Override annotations #14

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@krichter722
Copy link
Contributor

commented May 21, 2018

@override annotations help to detect architectural errors and respond
quicker to method changes. Unclear why the checkstyle configuration
which includes MissingOverride passes the validation if they're missing.

@coveralls

This comment has been minimized.

Copy link

commented May 21, 2018

Coverage Status

Coverage remained the same at 77.177% when pulling 6377a58 on krichter722:override into fc2818a on apache:master.

@garydgregory

This comment has been minimized.

Copy link
Contributor

commented May 21, 2018

Thank you for your report. I used Eclipse'd clean up feature to implement this change instead of applying this patch. Please verify and close.

Add missing @override annotations
@override annotations help to detect architectural errors and respond
quicker to method changes. Unclear why the checkstyle configuration
which includes MissingOverride passes the validation if they're missing.

@krichter722 krichter722 force-pushed the krichter722:override branch from 6377a58 to 30767b9 May 21, 2018

@garydgregory

This comment has been minimized.

Copy link
Contributor

commented May 21, 2018

If you have more, please update this PR based on what is in git master.

@krichter722

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2018

I made a mistake during rebase, the results are identical.

@krichter722 krichter722 deleted the krichter722:override branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.