From c1fbb3eba9f32af19c73d110eb02aa01a6f21e23 Mon Sep 17 00:00:00 2001 From: Gary Gregory Date: Sun, 14 Apr 2024 16:26:47 -0400 Subject: [PATCH] Use final and blocks --- .../jpeg/exif/ExifRewriterRoundtripTest.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java index c6a8dd27a..85644bbcf 100644 --- a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java +++ b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java @@ -90,11 +90,13 @@ private void assertTiffEquals(final TiffOutputSet sourceTiffOutputSet, final Tif final List sourceTags = new ArrayList<>(); final List duplicatedTags = new ArrayList<>(); - for (TiffOutputField field : sourceFields) + for (final TiffOutputField field : sourceFields) { sourceTags.add(field.tag); + } - for (TiffOutputField field : duplicateFields) + for (final TiffOutputField field : duplicateFields) { duplicatedTags.add(field.tag); + } final List missingTags = new ArrayList<>(sourceTags); missingTags.removeAll(duplicatedTags); @@ -106,7 +108,7 @@ private void assertTiffEquals(final TiffOutputSet sourceTiffOutputSet, final Tif assertTrue(missingTags.isEmpty(), "Missing tags: " + missingTags); } - for (TiffOutputField sourceField : sourceFields) { + for (final TiffOutputField sourceField : sourceFields) { final boolean isOffsetField = sourceField.tag == ExifTagConstants.EXIF_TAG_EXIF_OFFSET.tag || sourceField.tag == ExifTagConstants.EXIF_TAG_GPSINFO.tag || @@ -117,10 +119,11 @@ private void assertTiffEquals(final TiffOutputSet sourceTiffOutputSet, final Tif * Ignore offset fields. They may not be needed after rewrite * and their value changes anyway. */ - if (isOffsetField) + if (isOffsetField) { continue; + } - TiffOutputField duplicateField = duplicateDirectory.findField(sourceField.tag); + final TiffOutputField duplicateField = duplicateDirectory.findField(sourceField.tag); assertNotNull(duplicateField, "Field is missing: " + sourceField.tagInfo);