Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IO-596] Add DeleteFiles utility class #72

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jvz
Copy link
Member

commented Dec 26, 2018

This class provides configurable strategies to delete files and directories.

Adapted from the work done in jenkinsci/jenkins#3812.

Signed-off-by: Matt Sicker boards@gmail.com

@reviewbybees @garydgregory @jeffret-b

[IO-596] Add DeleteFiles utility class
This class provides configurable strategies to delete files and directories.

Signed-off-by: Matt Sicker <boards@gmail.com>
@jvz

This comment has been minimized.

Copy link
Member Author

commented Dec 26, 2018

Note that the build is failing as there is currently an existing unit test that tests a non-existent method.

throw new CompositeIOException(failureMessage(path, retriesAttempted, true), accumulatedErrors);
}
}
throw new CompositeIOException(failureMessage(path, maxRetries, false), accumulatedErrors);

This comment has been minimized.

Copy link
@asciborek

asciborek Dec 27, 2018

From what I can see this code will always cause throwing a new exception

This comment has been minimized.

Copy link
@jvz

jvz Dec 27, 2018

Author Member

Line 80 with the return will terminate the loop. This only returns successfully if none of the subpaths threw an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.