Permalink
Browse files

filtered out false positive findbugs warnings

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1090828 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information...
1 parent 7c246ad commit 3c95397456013bc221ac68ba2c889dad08705fa0 @maisonobe maisonobe committed Apr 10, 2011
Showing with 26 additions and 1 deletion.
  1. +26 −1 findbugs-exclude-filter.xml
@@ -26,9 +26,34 @@
<!-- Reason: Optimization to use == -->
<Match>
<Class name="org.apache.commons.lang3.BooleanUtils" />
- <Method name="toBoolean" />
+ <Or>
+ <Method name="toBoolean" />
+ <Method name="toBooleanObject" />
+ </Or>
<Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
</Match>
+ <Match>
+ <Class name="org.apache.commons.lang3.BooleanUtils" />
+ <Method name="toBoolean" />
+ <Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN" />
+ </Match>
+
+ <!-- Reason: Behavior documented in javadoc -->
+ <Match>
+ <Class name="org.apache.commons.lang3.BooleanUtils" />
+ <Or>
+ <Method name="negate" />
+ <Method name="toBooleanObject" />
+ </Or>
+ <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
+ </Match>
+
+ <!-- Reason: base class cannot be changed and field is properly checked against null so behavior is OK -->
+ <Match>
+ <Class name="org.apache.commons.lang3.text.ExtendedMessageFormat" />
+ <Method name="applyPattern" />
+ <Bug pattern="UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR" />
+ </Match>
<!-- Reason: Optimization to use == -->
<Match>

0 comments on commit 3c95397

Please sign in to comment.