Add an instanceof test in the implementation of equals(Object obj).#298
Closed
Kui-Liu wants to merge 1 commit intoapache:masterfrom
Kui-Liu:trunk
Closed
Add an instanceof test in the implementation of equals(Object obj).#298Kui-Liu wants to merge 1 commit intoapache:masterfrom Kui-Liu:trunk
Kui-Liu wants to merge 1 commit intoapache:masterfrom
Kui-Liu:trunk
Conversation
The equals(Object obj) method shouldn't make any assumptions about the type of obj. It should simply return false if obj is not the same type as this. http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS
Member
|
EDIT: thanks @PascalSchumacher hadn't seen the comment. Seen to be internal use only, so no need to change it. @brucekuiliu alternatively, we can just ignore that FindBugs error if necessary. |
Contributor
|
The comment above the statement explains why it is done this way. In case this is merged the comment should be removed. |
Author
|
I am sorry, I cannot provide any test cases. We found it is a potential vulnerability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The equals(Object obj) method shouldn't make any assumptions about the type of obj. It should simply return false if obj is not the same type as this.
http://findbugs.sourceforge.net/bugDescriptions.html#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS