[LANG-1238] Add overloaded methods to StringUtils with Pattern argument #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coms
changed the title
coms
changed the title
|
Thank you for your patch. IMO, we should stop overloading our already giant StringUtils class with RegEx versions of methods. We already have some confusion (my op.) with some "replace*" methods taking a plain String and others taking RegEx Strings. Why not have a new RegExUtils class where all String input are RegEx? We can then deprecate the few StringUtil methods that do take RegEx Strings. Thoughts? |
|
This refactoring looks like a good idea. Thanks for the suggestion. |
…ils to their own RegExUtils
# Conflicts: # src/main/java/org/apache/commons/lang3/RegExUtils.java # src/test/java/org/apache/commons/lang3/RegExUtilsTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the overloaded methods to StringUtils in order to work with precompiled regular expression Patterns.
https://issues.apache.org/jira/projects/LANG/issues/LANG-1238