Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANG-1474 documentation correction #442

Closed
wants to merge 1 commit into from
Closed

LANG-1474 documentation correction #442

wants to merge 1 commit into from

Conversation

verhas
Copy link
Contributor

@verhas verhas commented Aug 20, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.343% when pulling efe59a3 on verhas:LANG-1474 into f0534ba on apache:master.

@kinow kinow changed the title LAN-1474 documentation correction LANG-1474 documentation correction Aug 20, 2019
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing using master branch, the docs appear to be correct for me @verhas. Could you double check if you get the same using master, please? I've also kicked Travis as the error in one of the builds is most likely due to some glitch in their env.

Thanks for the pull request.

Bruno

@@ -3369,7 +3369,7 @@ public static boolean isAlphaSpace(final CharSequence cs) {
* <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
*
* <pre>
* StringUtils.isAnyBlank((String) null) = true
* StringUtils.isAnyBlank((String) null) = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried System.out.println(StringUtils.isAnyBlank((String) null)); using master branch and it printed true. Have you tried this code too?

@@ -3402,7 +3402,7 @@ public static boolean isAnyBlank(final CharSequence... css) {
* <p>Checks if any of the CharSequences are empty ("") or null.</p>
*
* <pre>
* StringUtils.isAnyEmpty((String) null) = true
* StringUtils.isAnyEmpty((String) null) = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto above for me.

@@ -3575,7 +3575,7 @@ public static boolean isMixedCase(final CharSequence cs) {
* <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
*
* <pre>
* StringUtils.isNoneBlank((String) null) = false
* StringUtils.isNoneBlank((String) null) = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one gave me false, as before.

@@ -3600,7 +3600,7 @@ public static boolean isNoneBlank(final CharSequence... css) {
* <p>Checks if none of the CharSequences are empty ("") or null.</p>
*
* <pre>
* StringUtils.isNoneEmpty((String) null) = false
* StringUtils.isNoneEmpty((String) null) = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as this one, false not true.

@Stzx
Copy link
Contributor

Stzx commented Aug 21, 2019

+1

@kinow
Copy link
Member

kinow commented Aug 21, 2019

@Stzx do you think the documentation changes are correct, or did you get the same as I did testing it? (sorry, couldn't tell if +1 was for my comment or for the PR change :)

@Stzx
Copy link
Contributor

Stzx commented Aug 21, 2019

@kinow Sorry.
Make you feel confused.
The conclusion of my test is the same as yours.

@kinow
Copy link
Member

kinow commented Aug 21, 2019

Thanks for testing, it was my bad too for not understanding it. Let's wait @verhas to comment now 👍

@kinow
Copy link
Member

kinow commented Aug 25, 2019

@verhas tested again today, and same behavior in master. Closing the PR, but in case you can confirm it's indeed an issue, feel free to re-open and reply with some step to confirm/reproduce it. Thanks!

@kinow kinow closed this Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants