Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LANG-794: Use os.name only when determining Windows versions #60

Closed
wants to merge 1 commit into from

Conversation

hzpz
Copy link

@hzpz hzpz commented Mar 28, 2015

As suggested in previous JIRA comments and according to some other sources (see http://lopica.sourceforge.net/os.html and http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/file/tip/src/windows/native/java/lang/java_props_md.c for example) the Windows version can be determined by os.name alone. I also added a constant for Windows Server 2012.

@britter
Copy link
Member

britter commented Mar 31, 2015

Looks good to me! I'll integrate this as soon as I have the time. In the mean time: do you want to be listed in the contributors section of pom.xml? If so, what is the name you want to be listed with?

@hzpz
Copy link
Author

hzpz commented Apr 1, 2015

Well, I haven't really done much (yet) but sure, I'd like that! My full name is Timo Kockert.

@britter
Copy link
Member

britter commented Apr 1, 2015

@hzpz oh you have done a lot. For example you prevented Commons Lang 3.4 to be released with the regression I introduced during my refactoring of SystemUtils (http://markmail.org/message/bbtjpzekwr4jlahm).

I'll have some time this evening to include your changes. Keep up the good work!

@asfgit asfgit closed this in e56332a Apr 3, 2015
asfgit pushed a commit that referenced this pull request Apr 27, 2015
…lso fixes #60 from github. Thanks to Timo Kockert.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/lang/trunk@1671040 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants