Adding .gitignore to commons-lang #8

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@mureinik
Contributor

mureinik commented Aug 24, 2013

Added .gitignore to the project in order to make working with git easier, and avoid accidentally commiting files that should not be commited.

These patches currently introduce two sets of ignored files:
First patch: Maven's build products (the target folder)
Second patch: IntelliJ IDEA's files

I'll happily add other files (e.g., Eclipse's file, other IDEs) if you wish.

@britter

This comment has been minimized.

Show comment Hide comment
@britter

britter Sep 1, 2013

Member

Hello Allon,

we have discussed your patch on the dev ML [1]. Your primary SCM is SVN but .gitignore files don't hurt anybody. As Oliver Hegen pointed out in the discussion, it makes sense to align .gitignore with svn:ignore, which is:

target
.iws
*.ipr
*.iml
.

*.log
maven-eclipse.xml
build.properties
site-content

Can you modify your patch to reflect svn:ignore?
TIA!

Benedikt

[1] http://markmail.org/message/wyfmtmhhp2efbelu

Member

britter commented Sep 1, 2013

Hello Allon,

we have discussed your patch on the dev ML [1]. Your primary SCM is SVN but .gitignore files don't hurt anybody. As Oliver Hegen pointed out in the discussion, it makes sense to align .gitignore with svn:ignore, which is:

target
.iws
*.ipr
*.iml
.

*.log
maven-eclipse.xml
build.properties
site-content

Can you modify your patch to reflect svn:ignore?
TIA!

Benedikt

[1] http://markmail.org/message/wyfmtmhhp2efbelu

@mureinik

This comment has been minimized.

Show comment Hide comment
@mureinik

mureinik Sep 1, 2013

Contributor

@britter - I updtatd my patches as per your comment.

Thanks for the input!

Contributor

mureinik commented Sep 1, 2013

@britter - I updtatd my patches as per your comment.

Thanks for the input!

@britter

This comment has been minimized.

Show comment Hide comment
@britter

britter Sep 1, 2013

Member

@mureinik - thanks for the update.

I've applied your patch to the SVN repository. It will probably not be visible at github until the next sync of the git mirror. Since SVN is our primary SCM, we cannot use the handy pull function provided by github :-) I have created an issue in the Apache JIRA [1] so that your contribution is traceable.

Thanks for contributing!
Benedikt

[1] https://issues.apache.org/jira/browse/LANG-913

Member

britter commented Sep 1, 2013

@mureinik - thanks for the update.

I've applied your patch to the SVN repository. It will probably not be visible at github until the next sync of the git mirror. Since SVN is our primary SCM, we cannot use the handy pull function provided by github :-) I have created an issue in the Apache JIRA [1] so that your contribution is traceable.

Thanks for contributing!
Benedikt

[1] https://issues.apache.org/jira/browse/LANG-913

@mureinik

This comment has been minimized.

Show comment Hide comment
@mureinik

mureinik Sep 1, 2013

Contributor

Thanks @britter !

Now that these files don't drive me crazy while doing "mvn status", I can start taking a look at real issues :-).

Contributor

mureinik commented Sep 1, 2013

Thanks @britter !

Now that these files don't drive me crazy while doing "mvn status", I can start taking a look at real issues :-).

@britter

This comment has been minimized.

Show comment Hide comment
@britter

britter Sep 2, 2013

Member

@mureinik you should better try "git status" ;-) just kidding! Keep on the good work!

Member

britter commented Sep 2, 2013

@mureinik you should better try "git status" ;-) just kidding! Keep on the good work!

@mureinik

This comment has been minimized.

Show comment Hide comment
@mureinik

mureinik Sep 2, 2013

Contributor

`-)

Contributor

mureinik commented Sep 2, 2013

`-)

@mureinik mureinik closed this Sep 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment