From 26f45b62a5aed774e5a71eace94a30bc39c88b80 Mon Sep 17 00:00:00 2001 From: Arturo Bernal Date: Tue, 13 Apr 2021 06:54:59 +0200 Subject: [PATCH] MATH-1571 - Collections Performance --- .../java/org/apache/commons/math4/ml/neuralnet/Network.java | 3 +-- .../org/apache/commons/math4/optim/linear/SimplexTableau.java | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/apache/commons/math4/ml/neuralnet/Network.java b/src/main/java/org/apache/commons/math4/ml/neuralnet/Network.java index 040963b98f..f5dfbd274d 100644 --- a/src/main/java/org/apache/commons/math4/ml/neuralnet/Network.java +++ b/src/main/java/org/apache/commons/math4/ml/neuralnet/Network.java @@ -179,8 +179,7 @@ public Iterator iterator() { * @see NeuronIdentifierComparator */ public Collection getNeurons(Comparator comparator) { - final List neurons = new ArrayList<>(); - neurons.addAll(neuronMap.values()); + final List neurons = new ArrayList<>(neuronMap.values()); Collections.sort(neurons, comparator); diff --git a/src/main/java/org/apache/commons/math4/optim/linear/SimplexTableau.java b/src/main/java/org/apache/commons/math4/optim/linear/SimplexTableau.java index e7576791d9..c306cfcc82 100644 --- a/src/main/java/org/apache/commons/math4/optim/linear/SimplexTableau.java +++ b/src/main/java/org/apache/commons/math4/optim/linear/SimplexTableau.java @@ -603,7 +603,7 @@ protected void dropPhase1Objective() { } // remove the columns in reverse order so the indices are correct - Integer[] drop = columnsToDrop.toArray(new Integer[columnsToDrop.size()]); + Integer[] drop = columnsToDrop.toArray(new Integer[0]); for (int i = drop.length - 1; i >= 0; i--) { columnLabels.remove((int) drop[i]); }