Permalink
Browse files

Stale comments

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/net/trunk@1741829 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information...
sebbASF committed May 1, 2016
1 parent 208e8af commit 7d421a35cc24625b247cedc28fb99ca32c3942ad
Showing with 10 additions and 121 deletions.
  1. +4 −4 checkstyle.xml
  2. +2 −2 pom.xml
  3. +1 −2 src/changes/changes.xml
  4. +1 −2 src/main/java/examples/ftp/FTPClientExample.java
  5. +0 −2 src/main/java/examples/telnet/TelnetClientExample.java
  6. +0 −3 src/main/java/org/apache/commons/net/DefaultDatagramSocketFactory.java
  7. +1 −2 src/main/java/org/apache/commons/net/PrintCommandListener.java
  8. +0 −3 src/main/java/org/apache/commons/net/ftp/FTPClient.java
  9. +0 −2 src/main/java/org/apache/commons/net/ftp/FTPFileEntryParserImpl.java
  10. +0 −3 src/main/java/org/apache/commons/net/ftp/FTPFileFilters.java
  11. +0 −3 src/main/java/org/apache/commons/net/ftp/FTPSTrustManager.java
  12. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/CompositeFileEntryParser.java
  13. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/ConfigurableFTPFileEntryParserImpl.java
  14. +0 −2 src/main/java/org/apache/commons/net/ftp/parser/DefaultFTPFileEntryParserFactory.java
  15. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/EnterpriseUnixFTPEntryParser.java
  16. +0 −2 src/main/java/org/apache/commons/net/ftp/parser/FTPTimestampParserImpl.java
  17. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java
  18. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java
  19. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParser.java
  20. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/NTFTPEntryParser.java
  21. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/NetwareFTPEntryParser.java
  22. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/OS2FTPEntryParser.java
  23. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/OS400FTPEntryParser.java
  24. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java
  25. +0 −1 src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java
  26. +0 −2 src/main/java/org/apache/commons/net/io/CopyStreamAdapter.java
  27. +0 −8 src/main/java/org/apache/commons/net/nntp/Article.java
  28. +1 −4 src/main/java/org/apache/commons/net/nntp/ArticleIterator.java
  29. +0 −4 src/main/java/org/apache/commons/net/nntp/NewsgroupIterator.java
  30. +0 −4 src/main/java/org/apache/commons/net/nntp/ReplyIterator.java
  31. +0 −33 src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
  32. +0 −1 src/main/java/org/apache/commons/net/ntp/TimeStamp.java
  33. +0 −1 src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java
  34. +0 −6 src/main/java/org/apache/commons/net/util/KeyManagerUtils.java
  35. +0 −3 src/main/java/org/apache/commons/net/util/TrustManagerUtils.java
  36. +0 −1 src/test/java/org/apache/commons/net/ftp/FTPClientConfigFunctionalTest.java
  37. +0 −2 src/test/java/org/apache/commons/net/ftp/parser/MLSDComparison.java
  38. +0 −2 src/test/java/org/apache/commons/net/ftp/parser/MLSxEntryParserTest.java
  39. +0 −1 src/test/java/org/apache/commons/net/telnet/TelnetClientTest.java
  40. +0 −1 src/test/java/org/apache/commons/net/telnet/TelnetTestResponder.java
  41. +0 −1 src/test/java/org/apache/commons/net/telnet/TelnetTestSimpleServer.java
  42. +0 −2 src/test/java/org/apache/commons/net/tftp/TFTPServer.java
  43. +0 −1 src/test/java/org/apache/commons/net/time/TimeTestSimpleServer.java
@@ -63,9 +63,9 @@ limitations under the License.
<!-- Modifier Checks -->
<!-- See http://checkstyle.sf.net/config_modifiers.html -->
<module name="ModifierOrder"/>
<!--module name="RedundantModifier"/-->
<!-- Checks for blocks. You know, those {}'s -->
<!-- See http://checkstyle.sf.net/config_blocks.html -->
<!--module name="AvoidNestedBlocks"/-->
@@ -81,7 +81,7 @@ limitations under the License.
<property name="allowMissingParamTags" value="true"/>
<property name="allowMissingThrowsTags" value="true"/>
</module>
</module>
<module name="SuppressionCommentFilter"/>
@@ -91,7 +91,7 @@ limitations under the License.
<property name="file" value="${config_loc}/checkstyle-suppressions.xml"/>
</module>
<!--
<!--
Allow comment to suppress checkstyle for a single line
e.g. // CHECKSTYLE IGNORE MagicNumber
-->
@@ -414,10 +414,10 @@ Supported protocols include: Echo, Finger, FTP, NNTP, NTP, POP3(S), SMTP(S), Tel
</configuration>
</plugin>
<!--
<!--
Allow exec:java to launch examples from the classpath
For example:
mvn -q exec:java -Dexec.arguments=FTPClientExample,-A,-l,hostname
-->
<plugin>
@@ -68,7 +68,7 @@ This is mainly a bug-fix release. See further details below.
This release is binary compatible with previous releases.
However it is not source compatible with releases before 3.4, as some methods were added to the interface NtpV3Packet in 3.4
The code now requires a minimum of Java 1.6.
Notable additions:
@@ -100,7 +100,6 @@ This is mainly a bug-fix release. See further details below.
IMAPExportMbox (example app) allows IMAP folders to be exported into an mbox file.
This is the inverse of the IMAPImportMbox example added previously
">
<action issue="NET-581" type="fix" dev="sebb">
SimpleSMTPHeader fails to supply the required Date: header
</action>
@@ -533,13 +533,12 @@ else if (doCommand != null)
private static CopyStreamListener createListener(){
return new CopyStreamListener(){
private long megsTotal = 0;
// @Override
@Override
public void bytesTransferred(CopyStreamEvent event) {
bytesTransferred(event.getTotalBytesTransferred(), event.getBytesTransferred(), event.getStreamSize());
}
// @Override
@Override
public void bytesTransferred(long totalBytesTransferred,
int bytesTransferred, long streamSize) {
@@ -278,7 +278,6 @@ else if(line.matches("^\\^[A-Z^]\\r?\\n?$"))
* (RECEIVED_DO, RECEIVED_DONT, RECEIVED_WILL, RECEIVED_WONT, RECEIVED_COMMAND)
* @param option_code - code of the option negotiated
***/
// @Override
@Override
public void receivedNegotiation(int negotiation_code, int option_code)
{
@@ -311,7 +310,6 @@ public void receivedNegotiation(int negotiation_code, int option_code)
* Reads lines from the TelnetClient and echoes them
* on the screen.
***/
// @Override
@Override
public void run()
{
@@ -42,7 +42,6 @@
* @return a new DatagramSocket
* @exception SocketException If the socket could not be created.
***/
// @Override
@Override
public DatagramSocket createDatagramSocket() throws SocketException
{
@@ -56,7 +55,6 @@ public DatagramSocket createDatagramSocket() throws SocketException
* @return a new DatagramSocket
* @exception SocketException If the socket could not be created.
***/
// @Override
@Override
public DatagramSocket createDatagramSocket(int port) throws SocketException
{
@@ -72,7 +70,6 @@ public DatagramSocket createDatagramSocket(int port) throws SocketException
* @return a new DatagramSocket
* @exception SocketException If the socket could not be created.
***/
// @Override
@Override
public DatagramSocket createDatagramSocket(int port, InetAddress laddr)
throws SocketException
@@ -146,7 +146,6 @@ public PrintCommandListener(PrintWriter writer, boolean suppressLogin, char eolM
__directionMarker = showDirection;
}
// @Override
@Override
public void protocolCommandSent(ProtocolCommandEvent event)
{
@@ -189,7 +188,7 @@ private String getPrintableString(String msg){
}
return msg;
}
// @Override
@Override
public void protocolReplyReceived(ProtocolCommandEvent event)
{
@@ -3647,7 +3647,6 @@ public int getReceiveDataSocketBufferSize() {
* provide non-standard configurations to the parser.
* @since 1.4
*/
// @Override
@Override
public void configure(FTPClientConfig config) {
this.__configuration = config;
@@ -3813,13 +3812,11 @@ private InputStream getBufferedInputStream(InputStream inputStream) {
parent.setSoTimeout(maxWait);
}
// @Override
@Override
public void bytesTransferred(CopyStreamEvent event) {
bytesTransferred(event.getTotalBytesTransferred(), event.getBytesTransferred(), event.getStreamSize());
}
// @Override
@Override
public void bytesTransferred(long totalBytesTransferred,
int bytesTransferred, long streamSize) {
@@ -47,7 +47,6 @@ public FTPFileEntryParserImpl()
* @return A string representing the next ftp entry or null if none found.
* @exception java.io.IOException thrown on any IO Error reading from the reader.
*/
// @Override
@Override
public String readNextEntry(BufferedReader reader) throws IOException
{
@@ -65,7 +64,6 @@ public String readNextEntry(BufferedReader reader) throws IOException
*
* @return <code>original</code> unmodified.
*/
// @Override
@Override
public List<String> preParse(List<String> original) {
return original;
@@ -28,7 +28,6 @@
* Accepts all FTPFile entries, including null.
*/
public static final FTPFileFilter ALL = new FTPFileFilter() {
// @Override
@Override
public boolean accept(FTPFile file) {
return true;
@@ -39,7 +38,6 @@ public boolean accept(FTPFile file) {
* Accepts all non-null FTPFile entries.
*/
public static final FTPFileFilter NON_NULL = new FTPFileFilter() {
// @Override
@Override
public boolean accept(FTPFile file) {
return file != null;
@@ -50,7 +48,6 @@ public boolean accept(FTPFile file) {
* Accepts all (non-null) FTPFile directory entries.
*/
public static final FTPFileFilter DIRECTORIES = new FTPFileFilter() {
// @Override
@Override
public boolean accept(FTPFile file) {
return file != null && file.isDirectory();
@@ -37,14 +37,12 @@
/**
* No-op
*/
// @Override
@Override
public void checkClientTrusted(X509Certificate[] certificates, String authType)
{
return;
}
// @Override
@Override
public void checkServerTrusted(X509Certificate[] certificates, String authType) throws CertificateException
{
@@ -54,7 +52,6 @@ public void checkServerTrusted(X509Certificate[] certificates, String authType)
}
}
// @Override
@Override
public X509Certificate[] getAcceptedIssuers()
{
@@ -41,7 +41,6 @@ public CompositeFileEntryParser(FTPFileEntryParser[] ftpFileEntryParsers)
this.ftpFileEntryParsers = ftpFileEntryParsers;
}
// @Override
@Override
public FTPFile parseFTPEntry(String listEntry)
{
@@ -98,7 +98,6 @@ public Calendar parseTimestamp(String timestampStr) throws ParseException {
* If it is null, a default configuration defined by
* each concrete subclass is used instead.
*/
// @Override
@Override
public void configure(FTPClientConfig config)
{
@@ -85,7 +85,6 @@
* the supplied key into an FTPFileEntryParser.
* @see FTPFileEntryParser
*/
// @Override
@Override
public FTPFileEntryParser createFileEntryParser(String key)
{
@@ -198,7 +197,6 @@ else if (ukey.indexOf(FTPClientConfig.SYST_L8) >= 0)
* @throws NullPointerException if {@code config} is {@code null}
* @since 1.4
*/
// @Override
@Override
public FTPFileEntryParser createFileEntryParser(FTPClientConfig config)
throws ParserInitializationException
@@ -83,7 +83,6 @@ public EnterpriseUnixFTPEntryParser()
* @param entry A line of text from the file listing
* @return An FTPFile instance corresponding to the supplied entry
*/
// @Override
@Override
public FTPFile parseFTPEntry(String entry)
{
@@ -164,7 +164,6 @@ public FTPTimestampParserImpl() {
* @param timestampStr The timestamp to be parsed
* @return a Calendar with the parsed timestamp
*/
// @Override
@Override
public Calendar parseTimestamp(String timestampStr) throws ParseException {
Calendar now = Calendar.getInstance();
@@ -364,7 +363,6 @@ private void setServerTimeZone(String serverTimeZoneId) {
* been configured.
* </p>
*/
// @Override
@Override
public void configure(FTPClientConfig config) {
DateFormatSymbols dfs = null;
@@ -93,7 +93,6 @@ public MLSxEntryParser()
super();
}
// @Override
@Override
public FTPFile parseFTPEntry(String entry) {
if (entry.startsWith(" ")) {// leading space means no facts are present
@@ -258,7 +258,6 @@ public MVSFTPEntryParser() {
* A line of text from the file listing
* @return An FTPFile instance corresponding to the supplied entry
*/
// @Override
@Override
public FTPFile parseFTPEntry(String entry) {
boolean isParsed = false;
@@ -125,7 +125,6 @@ public MacOsPeterFTPEntryParser(FTPClientConfig config)
* @param entry A line of text from the file listing
* @return An FTPFile instance corresponding to the supplied entry
*/
// @Override
@Override
public FTPFile parseFTPEntry(String entry) {
FTPFile file = new FTPFile();
@@ -96,7 +96,6 @@ public NTFTPEntryParser(FTPClientConfig config)
* @param entry A line of text from the file listing
* @return An FTPFile instance corresponding to the supplied entry
*/
// @Override
@Override
public FTPFile parseFTPEntry(String entry)
{
@@ -111,7 +111,6 @@ public NetwareFTPEntryParser(FTPClientConfig config) {
* @param entry A line of text from the file listing
* @return An FTPFile instance corresponding to the supplied entry
*/
// @Override
@Override
public FTPFile parseFTPEntry(String entry) {
@@ -84,7 +84,6 @@ public OS2FTPEntryParser(FTPClientConfig config)
* @param entry A line of text from the file listing
* @return An FTPFile instance corresponding to the supplied entry
*/
// @Override
@Override
public FTPFile parseFTPEntry(String entry)
{
@@ -278,7 +278,6 @@ public OS400FTPEntryParser(FTPClientConfig config)
}
// @Override
@Override
public FTPFile parseFTPEntry(String entry)
{
@@ -206,7 +206,6 @@ public UnixFTPEntryParser(FTPClientConfig config, boolean trimLeadingSpaces)
* @param entry A line of text from the file listing
* @return An FTPFile instance corresponding to the supplied entry
*/
// @Override
@Override
public FTPFile parseFTPEntry(String entry) {
FTPFile file = new FTPFile();
@@ -103,7 +103,6 @@ public VMSFTPEntryParser(FTPClientConfig config)
* @param entry A line of text from the file listing
* @return An FTPFile instance corresponding to the supplied entry
*/
// @Override
@Override
public FTPFile parseFTPEntry(String entry)
{
@@ -60,7 +60,6 @@ public CopyStreamAdapter()
* @param event The CopyStreamEvent fired by the copying of a block of
* bytes.
*/
// @Override
@Override
public void bytesTransferred(CopyStreamEvent event)
{
@@ -85,7 +84,6 @@ public void bytesTransferred(CopyStreamEvent event)
* This may be equal to CopyStreamEvent.UNKNOWN_STREAM_SIZE if
* the size is unknown.
*/
// @Override
@Override
public void bytesTransferred(long totalBytesTransferred,
int bytesTransferred, long streamSize)
Oops, something went wrong.

0 comments on commit 7d421a3

Please sign in to comment.