Minor improvements: #105
Merged
Minor improvements: #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arturobernalg
commented
Apr 15, 2022
arturobernalg
commented
- Use contains method.
- Avoid unnecessary boxing
- Avoid unnecessary unboxing
- Use Long.compare
|
AIUI Formatter.format requires Object parameters, so changing from Long.valueOf(long) to long just hides the boxing that must happen. Likewise for HashMap entries. The code generally uses explicit boxing and unboxing. This shows where it may be possible to improve data storage types to reduce conversions. Please remove the boxing changes from this PR |
garydgregory
requested changes
Apr 30, 2022
There was a problem hiding this comment.
Hi @arturobernalg
Thank you for the PR but please leave boxing and unboxing alone.
garydgregory
requested changes
May 2, 2022
HI @garydgregory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.