From cd052213432cdea872bc9c281903082ff4dc0798 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 15:46:29 +0300 Subject: [PATCH 01/20] made attribute transient --- .../commons/rdf/simple/experimental/RDFParseException.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/RDFParseException.java b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/RDFParseException.java index 16bdbc96f..ce77785fb 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/RDFParseException.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/RDFParseException.java @@ -22,7 +22,7 @@ public class RDFParseException extends Exception { private static final long serialVersionUID = 5427752643780702976L; - private final RDFParser builder; + private final transient RDFParser builder; public RDFParseException(final RDFParser builder) { super(); From 93d2f8e5c3d0cc10be075474bd7cc6474a8ea40d Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 15:47:53 +0300 Subject: [PATCH 02/20] replaced double quotes to simples --- .../commons/rdf/simple/experimental/AbstractRDFParser.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java index a9af156a4..343e6a4a4 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java @@ -507,7 +507,7 @@ private static Optional fileExtension(final Path path) { return Optional.empty(); } final String filenameStr = fileName.toString(); - final int last = filenameStr.lastIndexOf("."); + final int last = filenameStr.lastIndexOf('.'); if (last > -1) { return Optional.of(filenameStr.substring(last)); } From 1b01abbb5b1bb06eb05190dbf22f0e10ce1f9b75 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 15:49:10 +0300 Subject: [PATCH 03/20] replaced Optional<> nullcheck to isPresent() check --- .../main/java/org/apache/commons/rdf/simple/DatasetImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java b/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java index b1f6bdfbc..aab39c25c 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java @@ -130,7 +130,7 @@ public Stream stream() { public Stream stream(final Optional graphName, final BlankNodeOrIRI subject, final IRI predicate, final RDFTerm object) { final Optional newGraphName; - if (graphName == null) { + if (!graphName.isPresent()) { // Avoid Optional> ... newGraphName = null; } else { From d8d8d9b1db2aafc8d44562b63903a2d38aa1e9b2 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 15:50:20 +0300 Subject: [PATCH 04/20] replaced null return to Optional.empty() --- .../java/org/apache/commons/rdf/simple/DatasetGraphView.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/DatasetGraphView.java b/simple/src/main/java/org/apache/commons/rdf/simple/DatasetGraphView.java index 15515f24d..3604fa9b8 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/DatasetGraphView.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/DatasetGraphView.java @@ -91,7 +91,7 @@ public boolean contains(final Triple triple) { private Optional unionOrNamedGraph() { if (unionGraph) { - return null; + return Optional.empty(); } return Optional.ofNullable(namedGraph); } From 01ebc496dfefd0da29c299f1846922ae6fdcee05 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 15:56:18 +0300 Subject: [PATCH 05/20] removed unnecessary IllegalArgumentException declarations --- .../rdf/simple/experimental/AbstractRDFParser.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java index 343e6a4a4..e425514e9 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java @@ -237,7 +237,7 @@ public T rdfTermFactory(final RDF rdfTermFactory) { } @Override - public T contentType(final RDFSyntax rdfSyntax) throws IllegalArgumentException { + public T contentType(final RDFSyntax rdfSyntax) { final AbstractRDFParser c = clone(); c.contentTypeSyntax = Optional.ofNullable(rdfSyntax); c.contentType = c.contentTypeSyntax.map(syntax -> syntax.mediaType()); @@ -245,7 +245,7 @@ public T contentType(final RDFSyntax rdfSyntax) throws IllegalArgumentException } @Override - public T contentType(final String contentType) throws IllegalArgumentException { + public T contentType(final String contentType) { final AbstractRDFParser c = clone(); c.contentType = Optional.ofNullable(contentType); c.contentTypeSyntax = c.contentType.flatMap(RDFSyntax::byMediaType); @@ -261,7 +261,7 @@ public T base(final IRI base) { } @Override - public T base(final String base) throws IllegalArgumentException { + public T base(final String base) { return base(internalRdfTermFactory.createIRI(base)); } @@ -291,7 +291,7 @@ public T source(final IRI iri) { } @Override - public T source(final String iri) throws IllegalArgumentException { + public T source(final String iri) { final AbstractRDFParser c = clone(); c.resetSource(); c.sourceIri = Optional.ofNullable(iri).map(internalRdfTermFactory::createIRI); @@ -309,7 +309,7 @@ public T source(final String iri) throws IllegalArgumentException { * @throws IllegalArgumentException * If the IRI is not absolute */ - protected void checkIsAbsolute(final IRI iri) throws IllegalArgumentException { + protected void checkIsAbsolute(final IRI iri) { if (!URI.create(iri.getIRIString()).isAbsolute()) { throw new IllegalArgumentException("IRI is not absolute: " + iri); } From 03193884e65f2c4c24a4fbdf2288ad6edb6b1bd7 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 15:57:52 +0300 Subject: [PATCH 06/20] replaced lambdas with method references --- .../rdf/simple/experimental/AbstractRDFParser.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java index e425514e9..5b7604072 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java @@ -240,7 +240,7 @@ public T rdfTermFactory(final RDF rdfTermFactory) { public T contentType(final RDFSyntax rdfSyntax) { final AbstractRDFParser c = clone(); c.contentTypeSyntax = Optional.ofNullable(rdfSyntax); - c.contentType = c.contentTypeSyntax.map(syntax -> syntax.mediaType()); + c.contentType = c.contentTypeSyntax.map(RDFSyntax::mediaType); return c.asT(); } @@ -256,7 +256,7 @@ public T contentType(final String contentType) { public T base(final IRI base) { final AbstractRDFParser c = clone(); c.base = Optional.ofNullable(base); - c.base.ifPresent(i -> checkIsAbsolute(i)); + c.base.ifPresent(this::checkIsAbsolute); return c.asT(); } @@ -286,7 +286,7 @@ public T source(final IRI iri) { final AbstractRDFParser c = clone(); c.resetSource(); c.sourceIri = Optional.ofNullable(iri); - c.sourceIri.ifPresent(i -> checkIsAbsolute(i)); + c.sourceIri.ifPresent(this::checkIsAbsolute); return c.asT(); } @@ -295,7 +295,7 @@ public T source(final String iri) { final AbstractRDFParser c = clone(); c.resetSource(); c.sourceIri = Optional.ofNullable(iri).map(internalRdfTermFactory::createIRI); - c.sourceIri.ifPresent(i -> checkIsAbsolute(i)); + c.sourceIri.ifPresent(this::checkIsAbsolute); return source(internalRdfTermFactory.createIRI(iri)); } From 868bd65853f3ca58aabeb13e3299b29d9611ba7c Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 15:59:15 +0300 Subject: [PATCH 07/20] moved variables to their right places --- .../experimental/AbstractRDFParser.java | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java index 5b7604072..59dcf455d 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java @@ -64,6 +64,17 @@ public abstract class AbstractRDFParser> implemen // Basically only used for creating IRIs private static RDF internalRdfTermFactory = new SimpleRDF(); + private Optional rdfTermFactory = Optional.empty(); + private Optional contentTypeSyntax = Optional.empty(); + private Optional contentType = Optional.empty(); + private Optional base = Optional.empty(); + private Optional sourceInputStream = Optional.empty(); + private Optional sourceFile = Optional.empty(); + private Optional sourceIri = Optional.empty(); + private Consumer target; + private Optional targetDataset; + private Optional targetGraph; + /** * Get the set {@link RDF}, if any. * @@ -203,17 +214,6 @@ public Optional getSourceIri() { return sourceIri; } - private Optional rdfTermFactory = Optional.empty(); - private Optional contentTypeSyntax = Optional.empty(); - private Optional contentType = Optional.empty(); - private Optional base = Optional.empty(); - private Optional sourceInputStream = Optional.empty(); - private Optional sourceFile = Optional.empty(); - private Optional sourceIri = Optional.empty(); - private Consumer target; - private Optional targetDataset; - private Optional targetGraph; - @SuppressWarnings("unchecked") @Override public T clone() { From 9d89d249a868b72d9a91b8f5c5c72673ac44755e Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:05:04 +0300 Subject: [PATCH 08/20] corrected javadoc (deprecated) --- .../org/apache/commons/rdf/simple/SimpleRDFTermFactory.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDFTermFactory.java b/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDFTermFactory.java index 676f284bb..a16908843 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDFTermFactory.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDFTermFactory.java @@ -29,7 +29,7 @@ /** * A Simple implementation of {@link RDFTermFactory} *

- * This class is deprecated, use instead {@link SimpleRDF}. + * @deprecated use {@link SimpleRDF} instead. */ @Deprecated public class SimpleRDFTermFactory implements RDFTermFactory { From cbba0db986cd9117346125c2a3c4d0e07b6de008 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:07:08 +0300 Subject: [PATCH 09/20] removed unnecessary IllegalArgumentException declaration --- .../src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java b/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java index 6f6b2a55e..0c2eeded6 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java @@ -105,8 +105,7 @@ public Triple createTriple(final BlankNodeOrIRI subject, final IRI predicate, fi } @Override - public Quad createQuad(final BlankNodeOrIRI graphName, final BlankNodeOrIRI subject, final IRI predicate, final RDFTerm object) - throws IllegalArgumentException { + public Quad createQuad(final BlankNodeOrIRI graphName, final BlankNodeOrIRI subject, final IRI predicate, final RDFTerm object) { return new QuadImpl(graphName, subject, predicate, object); } } From f5dd857c2bd4d0598d4304ca65ce8a91a2c5ecdd Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:11:57 +0300 Subject: [PATCH 10/20] removed close, overridden method without body --- .../main/java/org/apache/commons/rdf/simple/DatasetImpl.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java b/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java index aab39c25c..0a5eee88d 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java @@ -191,10 +191,6 @@ public String toString() { } } - @Override - public void close() { - } - @Override public Graph getGraph() { return getGraph(null).get(); From 7f095a5f348b0645984728840c6cb94ab9050c73 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:13:13 +0300 Subject: [PATCH 11/20] simplified condition --- .../apache/commons/rdf/simple/DatasetImpl.java | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java b/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java index 0a5eee88d..a010608fc 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/DatasetImpl.java @@ -141,20 +141,10 @@ public Stream stream(final Optional graphName, final Blank final RDFTerm newObject = internallyMap(object); return getQuads(t -> { - if (newGraphName != null && !t.getGraphName().equals(newGraphName)) { - // This would check Optional.empty() == Optional.empty() - return false; - } - if (subject != null && !t.getSubject().equals(newSubject)) { - return false; - } - if (predicate != null && !t.getPredicate().equals(newPredicate)) { - return false; - } - if (object != null && !t.getObject().equals(newObject)) { - return false; - } - return true; + // This would check Optional.empty() == Optional.empty() + return !(newGraphName != null && !t.getGraphName().equals(newGraphName)) && !(subject != null && + !t.getSubject().equals(newSubject)) && !(predicate != null && + !t.getPredicate().equals(newPredicate)) && !(object != null && !t.getObject().equals(newObject)); }); } From 2798c64ba19c531681f45361e708e15051c81eac Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:14:10 +0300 Subject: [PATCH 12/20] removed unnecessary UnsupportedOperationException declaration --- .../src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java b/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java index 0c2eeded6..ccf57e093 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java @@ -73,7 +73,7 @@ public Graph createGraph() { } @Override - public Dataset createDataset() throws UnsupportedOperationException { + public Dataset createDataset() { return new DatasetImpl(this); } From d86af7db8ff8340e4495d5dd4250c94b18908e14 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:15:46 +0300 Subject: [PATCH 13/20] renamed field with right cases --- .../main/java/org/apache/commons/rdf/simple/SimpleRDF.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java b/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java index ccf57e093..2e5a21422 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/SimpleRDF.java @@ -53,7 +53,7 @@ static interface SimpleRDFTerm extends RDFTerm { /** * Unique salt per instance, for {@link #createBlankNode(String)} */ - private final UUID SALT = UUID.randomUUID(); + private final UUID salt = UUID.randomUUID(); @Override public BlankNode createBlankNode() { @@ -62,7 +62,7 @@ public BlankNode createBlankNode() { @Override public BlankNode createBlankNode(final String name) { - return new BlankNodeImpl(SALT, name); + return new BlankNodeImpl(salt, name); } @Override From 6011ee958af6d803e6d7645d707198e3bf863d68 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:20:03 +0300 Subject: [PATCH 14/20] removed deprecated RDF_PLAINLITERAL type --- .../main/java/org/apache/commons/rdf/simple/Types.java | 9 --------- 1 file changed, 9 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/Types.java b/simple/src/main/java/org/apache/commons/rdf/simple/Types.java index 308de71c3..6fdc62112 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/Types.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/Types.java @@ -39,14 +39,6 @@ public final class Types implements IRI, SimpleRDF.SimpleRDFTerm { */ public static final Types RDF_LANGSTRING = new Types("http://www.w3.org/1999/02/22-rdf-syntax-ns#langString"); - /** - * http://www.w3.org/1999/02/22-rdf-syntax-ns#PlainLiteral - * - * @deprecated Not used in RDF-1.1 - */ - @Deprecated - public static final Types RDF_PLAINLITERAL = new Types("http://www.w3.org/1999/02/22-rdf-syntax-ns#PlainLiteral"); - /** * http://www.w3.org/1999/02/22-rdf-syntax-ns#XMLLiteral */ @@ -243,7 +235,6 @@ public final class Types implements IRI, SimpleRDF.SimpleRDFTerm { final Set tempTypes = new LinkedHashSet<>(); tempTypes.add(RDF_HTML); tempTypes.add(RDF_LANGSTRING); - tempTypes.add(RDF_PLAINLITERAL); tempTypes.add(RDF_XMLLITERAL); tempTypes.add(XSD_ANYURI); tempTypes.add(XSD_BASE64BINARY); From 1295b4c7240c9ed98faf66ccf20717108a6c3fc8 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:20:59 +0300 Subject: [PATCH 15/20] removed commented-out code --- .../src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java | 1 - 1 file changed, 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java b/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java index 763a629eb..686890f06 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java @@ -64,7 +64,6 @@ public LiteralImpl(final String literal, final String languageTag) { throw new IllegalArgumentException("Invalid languageTag: " + languageTag, ex); } - // System.out.println(aLocale); this.dataType = Types.RDF_LANGSTRING; } From 27ba6e8838464fe6a6701608d9d835c9e7abc377 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:21:58 +0300 Subject: [PATCH 16/20] removed unnecessary TODO --- .../main/java/org/apache/commons/rdf/simple/LiteralImpl.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java b/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java index 686890f06..12c7ffa7f 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java @@ -54,8 +54,6 @@ public LiteralImpl(final String literal, final String languageTag) { this.lexicalForm = Objects.requireNonNull(literal); this.languageTag = Objects.requireNonNull(lowerCase(languageTag)); if (languageTag.isEmpty()) { - // TODO: Check against - // http://www.w3.org/TR/n-triples/#n-triples-grammar throw new IllegalArgumentException("Language tag can't be null"); } try { From c2ab58d0ffd98efc15f9faaf8e02d7b6574315c7 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:22:40 +0300 Subject: [PATCH 17/20] removed commented-out code #2 --- .../src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java | 1 - 1 file changed, 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java b/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java index 12c7ffa7f..6c11d3963 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/LiteralImpl.java @@ -91,7 +91,6 @@ public String ntriplesString() { replace("\n", "\\n")); // escaped to \n sb.append(QUOTE); - // getLanguageTag().ifPresent(s -> sb.append("@" + s)); if (getLanguageTag().isPresent()) { sb.append("@"); sb.append(getLanguageTag().get()); From 7a9562e9dbb3884d7cb16e91d403d69d16380645 Mon Sep 17 00:00:00 2001 From: "csaba.kothencz" Date: Wed, 19 Apr 2017 16:32:59 +0300 Subject: [PATCH 18/20] removed unnecessary IllegalStateException declaration --- .../commons/rdf/simple/experimental/AbstractRDFParser.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java index 59dcf455d..59adc72f9 100644 --- a/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java +++ b/simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java @@ -350,7 +350,7 @@ protected void checkSource() throws IOException { * @throws IllegalStateException * if base is required, but not set. */ - protected void checkBaseRequired() throws IllegalStateException { + protected void checkBaseRequired() { if (!base.isPresent() && sourceInputStream.isPresent() && !contentTypeSyntax.filter(t -> t == RDFSyntax.NQUADS || t == RDFSyntax.NTRIPLES).isPresent()) { throw new IllegalStateException("base iri required for inputstream source"); From 569cb5790c5eeae9f03a011166e4add4c4f6a1fb Mon Sep 17 00:00:00 2001 From: Imdapro Date: Thu, 4 May 2017 02:11:45 +0200 Subject: [PATCH 19/20] =?UTF-8?q?Branch=20k=C3=A9sz=C3=ADtve=20a=20tesztek?= =?UTF-8?q?hez,=20illetve=20lefedetts=C3=A9g=20vizsg=C3=A1lathoz.=20A=20ja?= =?UTF-8?q?coco=20hozz=C3=A1adva=20a=20projekthez.=20A=20"mvn=20-Dmaven.ja?= =?UTF-8?q?vadoc.skip=3Dtrue=20clean=20package"=20paranccsal=20futtass?= =?UTF-8?q?=C3=A1tok,=20mivel=20a=20k=C3=B3d=20javadoc=20comment=20hib?= =?UTF-8?q?=C3=A1kat=20tartalmaz.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- pom.xml | 52 +++++++++++++++++++++++++++++++++++++++++++++++++- simple/pom.xml | 46 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 97 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9294937a4..fe85d75aa 100644 --- a/pom.xml +++ b/pom.xml @@ -53,7 +53,7 @@ - https://docs.oracle.com/javase/8/docs/api/ + 0.9.1 @@ -74,6 +74,8 @@ 1.7.20 4.12 + + -Xdoclint:none @@ -265,6 +267,13 @@ ${slf4j.version} test + + + org.jacoco + jacoco-maven-plugin + 0.7.9 + + @@ -323,6 +332,47 @@ + + + org.jacoco + jacoco-maven-plugin + 0.7.9 + + + default-prepare-agent + + prepare-agent + + + + default-report + prepare-package + + report + + + + default-check + + check + + + + + BUNDLE + + + COMPLEXITY + COVEREDRATIO + 0.00 + + + + + + + +