Skip to content
Permalink
Browse files
Make some ivars final.
  • Loading branch information
garydgregory committed May 30, 2018
1 parent c476f02 commit 77dd4b425e8d511819960a1827994ccab2f95e4e
Showing 3 changed files with 8 additions and 8 deletions.
@@ -74,21 +74,21 @@ public class CommonsDistributionDetachmentMojo extends AbstractMojo {
* This list is supposed to hold the Maven references to the aforementioned artifacts so that we
* can upload them to svn after they've been detached from the Maven deployment.
*/
private List<Artifact> detachedArtifacts = new ArrayList<>();
private final List<Artifact> detachedArtifacts = new ArrayList<>();

/**
* A {@link Properties} of {@link Artifact} → {@link String} containing the sha1 signatures
* for the individual artifacts, where the {@link Artifact} is represented as:
* <code>groupId:artifactId:version:type=sha1</code>.
*/
private Properties artifactSha1s = new Properties();
private final Properties artifactSha1s = new Properties();

/**
* A {@link Properties} of {@link Artifact} → {@link String} containing the sha256 signatures
* for the individual artifacts, where the {@link Artifact} is represented as:
* <code>groupId:artifactId:version:type=sha1</code>.
*/
private Properties artifactSha256s = new Properties();
private final Properties artifactSha256s = new Properties();

/**
* The maven project context injection so that we can get a hold of the variables at hand.
@@ -36,11 +36,11 @@ public class ReadmeHtmlVelocityDelegate {
private static final String TEMPLATE = "resources/org/apache/commons/release/plugin"
+ "/velocity/README.vm";
/** This is supposed to represent the maven artifactId. */
private String artifactId;
private final String artifactId;
/** This is supposed to represent the maven version of the release. */
private String version;
private final String version;
/** The url of the site that gets set into the <code>README.html</code>. */
private String siteUrl;
private final String siteUrl;

/**
* The private constructor to be used by the {@link ReadmeHtmlVelocityDelegateBuilder}.
@@ -134,9 +134,9 @@ public List<Artifact> getAttachedArtifacts() {

public class DistributionDetachmentArtifactStub extends ArtifactStub {

private File artifact;
private final File artifact;

private String type;
private final String type;

public DistributionDetachmentArtifactStub(File file, String type, String artifactId) {
this.setArtifactId(artifactId);

0 comments on commit 77dd4b4

Please sign in to comment.