From 2b9f0c567f44109cbfe78f4a3732dcf2ce217d32 Mon Sep 17 00:00:00 2001 From: aherbert Date: Wed, 15 Jul 2020 17:12:09 +0100 Subject: [PATCH] Remove Assertions.equals using 0d --- .../ConstantContinuousDistributionTest.java | 4 ++-- .../ContinuousDistributionAbstractTest.java | 12 ++++++------ .../distribution/HypergeometricDistributionTest.java | 4 ++-- .../distribution/NormalDistributionTest.java | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ConstantContinuousDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ConstantContinuousDistributionTest.java index 6da78409f..758d290a6 100644 --- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ConstantContinuousDistributionTest.java +++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ConstantContinuousDistributionTest.java @@ -76,8 +76,8 @@ void testMoments() { ConstantContinuousDistribution dist; dist = new ConstantContinuousDistribution(-1); - Assertions.assertEquals(-1, dist.getMean(), 0d); - Assertions.assertEquals(0, dist.getVariance(), 0d); + Assertions.assertEquals(-1, dist.getMean()); + Assertions.assertEquals(0, dist.getVariance()); } @Test diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java index c2fdf9fcf..85739a8e2 100644 --- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java +++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java @@ -313,12 +313,12 @@ void testOutsideSupport() { final double below = lo - Math.ulp(lo); final double above = hi + Math.ulp(hi); - Assertions.assertEquals(0d, distribution.density(below), 0d); - Assertions.assertEquals(0d, distribution.density(above), 0d); - Assertions.assertEquals(Double.NEGATIVE_INFINITY, distribution.logDensity(below), 0d); - Assertions.assertEquals(Double.NEGATIVE_INFINITY, distribution.logDensity(above), 0d); - Assertions.assertEquals(0d, distribution.cumulativeProbability(below), 0d); - Assertions.assertEquals(1d, distribution.cumulativeProbability(above), 0d); + Assertions.assertEquals(0d, distribution.density(below)); + Assertions.assertEquals(0d, distribution.density(above)); + Assertions.assertEquals(Double.NEGATIVE_INFINITY, distribution.logDensity(below)); + Assertions.assertEquals(Double.NEGATIVE_INFINITY, distribution.logDensity(above)); + Assertions.assertEquals(0d, distribution.cumulativeProbability(below)); + Assertions.assertEquals(1d, distribution.cumulativeProbability(above)); } /** diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java index a662ea2eb..d2ed81f55 100644 --- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java +++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java @@ -305,7 +305,7 @@ void testZeroTrial() { for (int i = 1; i <= n; i++) { final double p = dist.probability(i); - Assertions.assertEquals(0, p, 0d, () -> "p=" + p); + Assertions.assertEquals(0, p, () -> "p=" + p); } } @@ -317,7 +317,7 @@ void testMath1356() { for (int s = 0; s <= n; s++) { final HypergeometricDistribution dist = new HypergeometricDistribution(n, m, s); final double p = dist.probability(s); - Assertions.assertEquals(1, p, 0d, () -> "p=" + p); + Assertions.assertEquals(1, p, () -> "p=" + p); } } diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NormalDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NormalDistributionTest.java index 0beae1ecc..87fd6a9a5 100644 --- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NormalDistributionTest.java +++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NormalDistributionTest.java @@ -180,7 +180,7 @@ void testLowerTail() { if (i < 39) { // make sure not top-coded Assertions.assertTrue(lowerTail > 0); } else { // make sure top coding not reversed - Assertions.assertEquals(0, lowerTail, 0d); + Assertions.assertEquals(0, lowerTail); } } } @@ -197,7 +197,7 @@ void testUpperTail() { if (i < 9) { // make sure not top-coded Assertions.assertTrue(upperTail < 1); } else { // make sure top coding not reversed - Assertions.assertEquals(1, upperTail, 0d); + Assertions.assertEquals(1, upperTail); } } }