Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Statistics-7] Descriptive module. This package provides descriptive statistics of data for example mean, variance and moments. #14

Conversation

Projects
None yet
2 participants
@virendrasinghrp
Copy link
Contributor

commented May 23, 2019

Initiation of "commons-statistics-descriptive" module

virendrasinghrp added some commits May 20, 2019

Merge pull request #1 from apache/master
Updated commons-statistics with commons-distribution & commons-regression
STATISTICS-7- adding a new 'commons-statistics-descriptive' module/ma…
…ven project for Descriptive Statistics
*/
/**
*
* Hello World program.

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

This should be updated to something more appropriate, e.g.

The package provides descriptive statistics of data for example mean, variance and moments.

This comment has been minimized.

Copy link
@virendrasinghrp

virendrasinghrp May 23, 2019

Author Contributor

Ok, done.

pom.xml Outdated
</modules>

</project>

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

Have you missed an end of line here?

@virendrasinghrp virendrasinghrp changed the title Statistics 7 descriptive module Statistics 7 descriptive module. The package provides descriptive statistics of data for example mean, variance and moments. May 23, 2019

pom.xml Outdated
@@ -14,8 +14,7 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
--><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

You have joined the end of the header comment to the start of the xml document

This comment has been minimized.

Copy link
@virendrasinghrp

virendrasinghrp May 23, 2019

Author Contributor

On my system It's not joined

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

Let's discuss this on slack as some issues can be resolved easily.

@virendrasinghrp virendrasinghrp changed the title Statistics 7 descriptive module. The package provides descriptive statistics of data for example mean, variance and moments. [Statistics-7] Descriptive module. This package provides descriptive statistics of data for example mean, variance and moments. May 23, 2019

<!-- Workaround to avoid duplicating config files. -->
<statistics.parent.dir>${basedir}/..</statistics.parent.dir>

<maven.javadoc.skip>true</maven.javadoc.skip>

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

Indentation...

This comment has been minimized.

Copy link
@virendrasinghrp

virendrasinghrp May 23, 2019

Author Contributor

what?

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

The XML indentation is incorrect. I would also add a TODO comment stating that this is a temporary workaround as the module initialisation does not contain documentable source code.

</dependency>
</dependencies>

<build>

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

You do not need the section. Everything is inherited from the parent pom.

This comment has been minimized.

Copy link
@virendrasinghrp

virendrasinghrp May 23, 2019

Author Contributor

which section?

<maven.javadoc.skip>true</maven.javadoc.skip>
</properties>

<dependencies>

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

The parent pom already has the junit dependency so you do not need this section.

This comment has been minimized.

Copy link
@virendrasinghrp

virendrasinghrp May 23, 2019

Author Contributor

I'll remove it.

<version>0.1-SNAPSHOT</version>
<name>Apache Commons Statistics Descriptive</name>
<description>Descriptive/Summary Statistics.</description>
<url>http://maven.apache.org</url>

This comment has been minimized.

Copy link
@aherbert

aherbert May 23, 2019

Contributor

This is auto-generated. It can be removed. It is not the project url.

This comment has been minimized.

Copy link
@virendrasinghrp

virendrasinghrp May 23, 2019

Author Contributor

ok, I'll remove it

@aherbert

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

All the standard files look good. The module pom has generated stuff that can be removed.

virendrasinghrp added some commits May 24, 2019

asfgit pushed a commit that referenced this pull request May 25, 2019

STATISTICS-7: Adding a new 'commons-statistics-descriptive' module.
This is a single commit comprising all changes from Virendra Singhrp to initialise the module.

Close #14.

@aherbert aherbert closed this May 25, 2019

@aherbert

This comment has been minimized.

Copy link
Contributor

commented May 25, 2019

Closed after manual merge into develop.

@virendrasinghrp virendrasinghrp deleted the virendrasinghrp:STATISTICS-7-descriptive_module branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.