Skip to content
Permalink
Browse files
fix(regression): Cannot read version of undefined caused by Java refa…
  • Loading branch information
breautek committed Mar 30, 2021
1 parent d22af02 commit 1ec87634d447235f9c2003e12a4d921e6070b8aa
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
@@ -135,6 +135,8 @@ module.exports.check_gradle = function () {

/**
* Checks for the java installation and correct version
*
* Despite the name, it should return the Java version value, it's used by the Cordova CLI.
*/
module.exports.check_java = async function () {
const javaVersion = await java.getVersion();
@@ -145,6 +147,8 @@ module.exports.check_java = async function () {
'Check your ANDROID_SDK_ROOT / JAVA_HOME / PATH environment variables.'
);
}

return javaVersion;
};

// Returns a promise.
@@ -56,6 +56,14 @@ describe('check_reqs', function () {

await expectAsync(check_reqs.check_java()).toBeRejectedWithError(CordovaError, /Requirements check failed for JDK 9999.9999.9999! Detected version: 1.8.0/);
});

it('should return the version', async () => {
check_reqs.__set__({
java: { getVersion: async () => ({ version: '1.8.0' }) }
});

await expectAsync(check_reqs.check_java()).toBeResolvedTo({ version: '1.8.0' });
});
});

describe('check_android', function () {

0 comments on commit 1ec8763

Please sign in to comment.