Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import type definitions from obsolete cordova-plugin-splashscreen #1489

Merged
merged 1 commit into from Sep 13, 2022

Conversation

peitschie
Copy link
Contributor

Platforms affected

Affects TypeScript enabled projects only

Motivation and Context

Type definitions to allow programmatic control of the splashscreen are needed in cordova-android now that cordova-plugin-splashscreen was obsoleted as part of the Android 12 splash support.

Description

Import the current type definitions from cordova-plugin-splashscreen and expose them for use within a typescript project.

Testing

I've imported this into an existing TypeScript-based application that has cordova-plugin-splashscreen removed, and ensured that TypeScript compilation produces no warnings or errors

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@peitschie
Copy link
Contributor Author

Relates to apache/cordova-ios#1255

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Merging #1489 (98d0628) into master (60e3803) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1489   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files          21       21           
  Lines        1748     1748           
=======================================
  Hits         1263     1263           
  Misses        485      485           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types/index.d.ts Outdated Show resolved Hide resolved
@breautek
Copy link
Contributor

Hah, I forgot the show api no longer exists due to the native android splashscreen implementation, really should have caught that earlier!

Anyway, thanks for your contribution, I'm sure the typescript users will be pleased when this is rolled into our next release.

@breautek breautek merged commit 248257b into apache:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants