CB-11117: Use FileUpdater to optimize prepare for android platform #295
Conversation
|
@vladimir-kotikov @infil00p please review |
Current coverage is 34.14%@@ master #295 diff @@
==========================================
Files 11 11
Lines 947 949 +2
Methods 194 195 +1
Messages 0 0
Branches 153 153
==========================================
Hits 324 324
- Misses 623 625 +2
Partials 0 0
|
|
|
||
| this._config = updateConfigFilesFrom(cordovaProject.projectConfig, | ||
| this._munger, this.locations); | ||
|
|
||
| // Update own www dir with project's www assets and plugins' assets and js-files | ||
| return Q.when(updateWwwFrom(cordovaProject, this.locations)) | ||
| return Q.when(updateWww.call(self, cordovaProject)) |
There was a problem hiding this comment.
I'd rather not to pass this reference to this method, especially if the only thing we need is a couple of properties from locations object (this.locations.platformWww and this.locations.www at L120). Maybe just pass these properties as an arguments, or revert to previous signature?
There was a problem hiding this comment.
I had been using this in a few more places, before I moved some things around. I agree it is not really needed now; I'll clean that up everywhere.
|
I updated the PR based on feedback. As mentioned in the other comment I've kept the clean functionality, but it is now skipped when not invoked via the CLI. |
|
LGTM |
This uses the FileUpdater module added in apache/cordova-lib#429 to optionally skip copying files that didn't change. Some refactoring was required because previously the target directories would just be wiped before copying; now we need to map out the source and target directories so the FileUpdater has the necessary information to determine the optimal set of file operations.