Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12077: Fix paths for Android icons/splashscreens #343

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@dpogue
Copy link
Member

commented Oct 28, 2016

Platforms affected

Android

What does this PR do?

Fix icons and splashscreens defined in config.xml copying into the project to override the default Cordova ones.

What testing has been done on this change?

Tested locally with cordova-cli

@codecov-io

This comment has been minimized.

Copy link

commented Oct 28, 2016

Current coverage is 35.21% (diff: 0.00%)

Merging #343 into master will not change coverage

@@             master       #343   diff @@
==========================================
  Files            12         12          
  Lines          1028       1028          
  Methods         202        202          
  Messages          0          0          
  Branches        169        169          
==========================================
  Hits            362        362          
  Misses          666        666          
  Partials          0          0          

Powered by Codecov. Last update 1f06176...db198eb

@asfgit asfgit closed this in 854946e Oct 31, 2016

@mattroth

This comment has been minimized.

Copy link

commented Nov 2, 2016

Does anyone have a work around? How can I update cordova-android on my development machine with this above fix prior to the next release?

@jcesarmobile

This comment has been minimized.

Copy link
Member

commented Nov 3, 2016

you can use cordova-android from master with cordova platform add android@https://github.com/apache/cordova-android or the previous version with cordova platform add android@5.2.2

@rodrigograca31

This comment has been minimized.

Copy link

commented Nov 25, 2016

Notes:
This issue is solved in cordova-android 6.1.0 but if you try cordova platform update android at this moment doesn't update to 6.1.0.

Run

cordova platform update android@6.1.0 --save
cordova platform rm android
cordova platform add android

to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.