Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12605 In Windows get Android studio path from the registry #387

Closed
wants to merge 1 commit into from

Conversation

purplecabbage
Copy link
Contributor

Platforms affected

Android on windows

What does this PR do?

Allows installs of Android Studio in places other than C://

What testing has been done on this change?

Tested with and without registry value present

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

Codecov Report

Merging #387 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
- Coverage   39.52%   39.44%   -0.08%     
==========================================
  Files          16       16              
  Lines        1551     1554       +3     
  Branches      277      278       +1     
==========================================
  Hits          613      613              
- Misses        938      941       +3
Impacted Files Coverage Δ
bin/templates/cordova/lib/check_reqs.js 44.29% <0%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6e898...656fc19. Read the comment docs.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested on a Windows 10 VM, however only with Android Studio installed into the default C:\Program Files\Android\Android Studio location (I also have the preview version of Android Studio installed in a sibling directory).

Confirmed that the getASPath.bat file works as expected on its own. Creating and building a project on Win10 seems to work fine with these changes.

@infil00p
Copy link
Member

LGTM, pulling in.

@asfgit asfgit closed this in 5cc14b8 Jun 22, 2017
infil00p pushed a commit to infil00p/cordova-android that referenced this pull request Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants