Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(android) add missing cast for cdvMinSdkVersion #551

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
5 participants
@DavidWiesner
Copy link
Contributor

DavidWiesner commented Nov 14, 2018

Platforms affected

  • android

What does this PR do?

What testing has been done on this change?

  • none

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   61.98%   61.98%           
=======================================
  Files          17       17           
  Lines        1978     1978           
  Branches      369      369           
=======================================
  Hits         1226     1226           
  Misses        752      752

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576ad18...a4caa87. Read the comment docs.

@dpogue

dpogue approved these changes Nov 14, 2018

Copy link
Member

dpogue left a comment

Thanks!

@dpogue dpogue merged commit cf5915a into apache:master Nov 14, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -117,7 +117,7 @@ if (ext.cdvReleaseSigningPropertiesFile == null && file('../release-signing.prop
// Cast to appropriate types.
ext.cdvBuildMultipleApks = cdvBuildMultipleApks == null ? false : cdvBuildMultipleApks.toBoolean();
ext.cdvVersionCodeForceAbiDigit = cdvVersionCodeForceAbiDigit == null ? false : cdvVersionCodeForceAbiDigit.toBoolean();
ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? defaultMinSdkVersion : cdvMinSdkVersion
ext.cdvMinSdkVersion = cdvMinSdkVersion == null ? defaultMinSdkVersion : Integer.parseInt('' + cdvMinSdkVersion)

This comment has been minimized.

Copy link
@janpio

janpio Nov 14, 2018

Contributor

why the empty string added?

This comment has been minimized.

Copy link
@brodybits

brodybits Nov 14, 2018

Contributor

Some kind of recasting. This is code that was done in bf327f3 but got lost somehow.

This comment has been minimized.

Copy link
@DavidWiesner

DavidWiesner Nov 14, 2018

Author Contributor

To be cast the value to a string if it was an integer before

This comment has been minimized.

Copy link
@janpio

janpio Nov 14, 2018

Contributor

Ah, Integer.parseInt won't like to get an Int already?

brodybits added a commit to brodybits/cordova-android that referenced this pull request Nov 14, 2018

@brodybits brodybits referenced this pull request Nov 14, 2018

Merged

7.1.3 patch updates #555

7 of 7 tasks complete

brodybits added a commit to brodybits/cordova-android that referenced this pull request Nov 14, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Nov 15, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Nov 16, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Nov 16, 2018

brodybits added a commit to brodybits/cordova-android that referenced this pull request Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.