Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode #43

Merged
merged 2 commits into from Mar 4, 2020
Merged

Dark mode #43

merged 2 commits into from Mar 4, 2020

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 1, 2019

Closes #41 .

Platforms affected

iOS, possibly Android

Motivation and Context

iOS 13 and macOS Mojave introduced dark mode support, and it is available to web content. Android 10 introduces similar dark mode support.

Description

Add media queries and meta tags to support dark mode.

Testing

This has been tested in the iOS 13 simulator.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

erisu
erisu approved these changes Nov 6, 2019
Copy link
Member

@erisu erisu left a comment

👍

@erisu erisu added this to the 4.1.0 milestone Nov 6, 2019
@erisu erisu merged commit 2a382ff into apache:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants