Add missing <meta charset="UTF-8"> and make HTML standard#58
Merged
Conversation
- Remove unnecessary codes meet the standard coding for html. - Adding `user-scalable=no` to meta `viewport` to prevent users to scale webview, because it is work as an standard app.
- Add missing `<meta charset="UTF-8">` to index.html
- Add missing `<meta charset="UTF-8">` to index.html
mosabab
changed the title
raphinesse
requested changes
Dec 4, 2019
raphinesse
left a comment
raphinesse
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, except for the charset issue I commented on.
Contributor
Author
|
Looks good now |
raphinesse
approved these changes
Dec 4, 2019
raphinesse
left a comment
raphinesse
left a comment
Contributor
There was a problem hiding this comment.
All good now. Thank you very much for your contribution! 🥇
Contributor
Author
|
Thank you my friend :) |
Contributor
Author
|
Anyway lowercase or uppercase not affect the code. And if you wrote it in small letter, it also work. Also in xml charset default written in UTF-8 Also for doctype html It is the same, but the default is DOCTYPE html You can refer to those standards from w3.org, or w3schools Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<meta charset="UTF-8">to<head>section.type="text/css",type="text/javascript". Because those types is default inHTML5user-scalable=noto metaviewportto prevent users to scale webview, because by default, mobile apps should not allow users to scale the main webview.Platforms affected
Motivation and Context
Description
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))