Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing <meta charset="UTF-8"> and make HTML standard #58

Merged
merged 5 commits into from Dec 4, 2019

Conversation

mosabab
Copy link
Contributor

@mosabab mosabab commented Dec 4, 2019

  • Add missing <meta charset="UTF-8"> to <head> section.
  • Remove unnecessary codes to meet the standard coding for HTML, for e.g.: type="text/css", type="text/javascript". Because those types is default in HTML5
  • Adding user-scalable=no to meta viewport to prevent users to scale webview, because by default, mobile apps should not allow users to scale the main webview.

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

mosabab added 3 commits Dec 4, 2019
- Remove unnecessary codes meet the standard coding for html.
- Adding `user-scalable=no` to meta `viewport` to prevent users to scale webview, because it is work as an standard app.
- Add missing `<meta charset="UTF-8">` to index.html
- Add missing `<meta charset="UTF-8">` to index.html
@mosabab mosabab changed the title Optimize index.html and remove unnecessary codes Add missing <meta charset="UTF-8"> and make HTML standard Dec 4, 2019
Copy link
Contributor

@raphinesse raphinesse left a comment

Looks good to me, except for the charset issue I commented on.

template_src/www/index.html Outdated Show resolved Hide resolved
@mosabab
Copy link
Contributor Author

@mosabab mosabab commented Dec 4, 2019

Looks good now

Copy link
Contributor

@raphinesse raphinesse left a comment

All good now. Thank you very much for your contribution! 🥇

@mosabab
Copy link
Contributor Author

@mosabab mosabab commented Dec 4, 2019

Thank you my friend :)

@mosabab
Copy link
Contributor Author

@mosabab mosabab commented Dec 4, 2019

Anyway lowercase or uppercase not affect the code.

And if you wrote it in small letter, it also work.
But in html5 standard
The charset utf defined it in capital UTF-8

Also in xml charset default written in UTF-8

Also for doctype html
If you write it in :
DOCTYPE html
Or
doctype html

It is the same, but the default is DOCTYPE html

You can refer to those standards from w3.org, or w3schools

Regards

@raphinesse raphinesse merged commit 1316332 into apache:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants