Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper error code and message when failing #295

Merged
merged 1 commit into from Jun 18, 2018

Conversation

@raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Jun 18, 2018

Prior to this, the CLI would exit with UnhandledPromiseRejectionWarning
and a full stack trace when an error occurred.

With this change, set an error code indicating failure and only display
the error message by default. The stack trace is printed with --verbose.

Furthermore, the loud-rejection handler is registered to fail properly
if any rejected promises snuck past our handling.

@dpogue
dpogue approved these changes Jun 18, 2018
Copy link
Member

@dpogue dpogue left a comment

👍

dpogue added a commit to dpogue/seymour that referenced this pull request Jun 18, 2018
Modelled after apache/cordova-cli#295
@raphinesse raphinesse force-pushed the raphinesse:loud-rejection branch from b083ae4 to bed02b0 Jun 18, 2018
Prior to this, the CLI would exit with UnhandledPromiseRejectionWarning
and a full stack trace when an error occurred.

With this change, set an error code indicating failure and only display
the error message by default. The stack trace is printed with --verbose.

Furthermore, the loud-rejection handler is registered to fail properly
if any rejected promises snuck past our handling.
@raphinesse raphinesse force-pushed the raphinesse:loud-rejection branch from bed02b0 to fc4022e Jun 18, 2018
@raphinesse raphinesse merged commit bbb14fb into apache:master Jun 18, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raphinesse raphinesse deleted the raphinesse:loud-rejection branch Jun 18, 2018
@raphinesse raphinesse changed the title Have proper error code and message when failing Proper error code and message when failing Jun 18, 2018
@brodybits brodybits mentioned this pull request Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.