Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upProper error code and message when failing #295
Conversation
added a commit
to dpogue/seymour
that referenced
this pull request
Jun 18, 2018
raphinesse
merged commit bbb14fb
into
apache:master
Jun 18, 2018
raphinesse
deleted the
raphinesse:loud-rejection
branch
Jun 18, 2018
raphinesse
changed the title from
Have proper error code and message when failing
to
Proper error code and message when failing
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
raphinesse commentedJun 18, 2018
Prior to this, the CLI would exit with
UnhandledPromiseRejectionWarningand a full stack trace when an error occurred.
With this change, set an error code indicating failure and only display
the error message by default. The stack trace is printed with --verbose.
Furthermore, the loud-rejection handler is registered to fail properly
if any rejected promises snuck past our handling.