Proper error code and message when failing #295
Merged
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
added a commit
to dpogue/seymour
that referenced
this pull request
Jun 18, 2018
Modelled after apache/cordova-cli#295
raphinesse
force-pushed
the
loud-rejection
branch
from
b083ae4 to
bed02b0
Compare
Prior to this, the CLI would exit with UnhandledPromiseRejectionWarning and a full stack trace when an error occurred. With this change, set an error code indicating failure and only display the error message by default. The stack trace is printed with --verbose. Furthermore, the loud-rejection handler is registered to fail properly if any rejected promises snuck past our handling.
raphinesse
force-pushed
the
loud-rejection
branch
from
bed02b0 to
fc4022e
Compare
raphinesse
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, the CLI would exit with
UnhandledPromiseRejectionWarningand a full stack trace when an error occurred.
With this change, set an error code indicating failure and only display
the error message by default. The stack trace is printed with --verbose.
Furthermore, the loud-rejection handler is registered to fail properly
if any rejected promises snuck past our handling.