Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #312

Merged
merged 3 commits into from Aug 30, 2018
Merged

Update dependencies #312

merged 3 commits into from Aug 30, 2018

Conversation

@raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Aug 30, 2018

  • No update to Jasmine 3.2 because of apache/cordova-lib#639
  • Updated insight to resolve #300
    • To resolve #300, updating to 0.9.0 would have sufficed.
    • Because of yeoman/insight@dae6dd4 users will be asked again whether they want data to be collected. However, with the upcoming major release, I think users could see why they get asked permission again.
@raphinesse raphinesse force-pushed the raphinesse:dep-up branch from b7167d6 to 193ba72 Aug 30, 2018
- To resolve the lodash warning, 0.9.0 would have sufficed.
- Because of yeoman/insight@dae6dd4
  users will be asked again whether they want data to be collected

Fixes #300
@raphinesse raphinesse force-pushed the raphinesse:dep-up branch from 8682af6 to 2e12690 Aug 30, 2018
@dpogue
dpogue approved these changes Aug 30, 2018
Copy link
Member

@dpogue dpogue left a comment

👍

@dpogue dpogue merged commit 2aca200 into apache:master Aug 30, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raphinesse raphinesse deleted the raphinesse:dep-up branch Aug 30, 2018
@brodybits brodybits mentioned this pull request Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants