Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec label for build tests #364

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Fix spec label for build tests #364

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/cli.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ describe('cordova cli', () => {
});
});

describe('Test#004 : project commands other than plugin and platform', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this "Test#004 : project commands other than plugin and platform" go then? was this always a faulty description making no sense?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "project commands other than plugin and platform", with no test number, was introduced in c775d2a back in 2013. Back then the description was strictly correct but not the most helpful since the only project command tested in that section was "build". No longer correct as of 8956c75 where tests of "config" were introduced.

Test numbering was introduced in 2652919, where the described block starting here was mistakenly given a test number.

describe('build', () => {
beforeEach(() => {
spyOn(cordova, 'build').and.returnValue(Promise.resolve());
});
Expand Down