Skip to content
Permalink
Browse files
Update code-reviews.md to no longer mention reviewboard
  • Loading branch information
agrieve committed Jan 9, 2015
1 parent 7a568a0 commit 03779576da154c1ec4c0df18d07476ab0cfd331d
Showing 1 changed file with 4 additions and 19 deletions.
@@ -21,23 +21,8 @@

# Code Reviews

TODO: Review Board didn't really work out :(. Come up with something better.
We use GitHub pull requests for code reviews.
1. Commit to a branch on your own fork of the repo that you're changing
2. Use GitHub to create a pull request
3. Email out the link to it

* Use http://reviews.apache.org/ to create a review request.
* You will need a Review Board userid and password. One can be requested from the site.
* By default, the ML will be notified of your review request.
* If you have someone in particular that you would like approval from, be sure to add them in "People" field of the review.
* To create your review request is to use [post-review](http://www.reviewboard.org/docs/rbtools/dev/) (RBTools) from the repo with the change, only if the repo contains the file '.reviewboardrc'
Currently the following repos contain .reviewboardrc:
cordova-coho
cordova-cli
cordova-android
cordova-ios
cordova-js

* If you don't want to use post-review tool, then on the web site:
* Click "New Review Request"
* On your workstation do a git diff and pipe the output to a file. In the new request, select the git repo, the base dir where you did the diff, upload the diff file you created, and click Create.
* On the next web page, fill in the description text, the name of the Branch (i.e., "master"), the Bug (i.e., "CB-4960"), the Description and the Testing Done fields. If you want a review from a specific person, enter their userid / name in the People field. If you want input from the whole community, enter "cordova" in the Groups field. Click the Submit button.
* After you have received sufficient feedback, click the button to mark your review as Discarded or Submitted [to a stream].
* If you don't want to use ReviewBoard you can use Github Pull Request

0 comments on commit 0377957

Please sign in to comment.