CB-14064: Dependency updates & drop node4 CI

[dpogue]

Also added the pull request issue template (copied from cordova-lib) since I noticed that was missing

[raphinesse]

@dpogue The update of shelljs breaks the AppVeyor build on Windows. shell.which('ls') seems to return something unexpected here.

[dpogue]

Yeah, I'm going to get a Windows VM set up to run the tests locally on Windows and see what's going on. I'd really like to not to be stuck on an old version of shelljs :\

[raphinesse]

I got a dual boot setup here, let me take a quick look at it.

[raphinesse]

Well basically, shelljs returns ShellString instances, while pathname.extname expects a plain string. This behavior is not Windows specific either. It's just that the problematic code in superspawn.js only is active on Windows.

So we only need to unwrap the encapsulated string. If I replace the line I linked above with the following, all tests pass on my Windows installation using node 8:

cmd = String(shell.which(cmd) || cmd);

[codecov-io]

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          19       19           
  Lines        1768     1768           
  Branches      376      376           
=======================================
  Hits         1507     1507           
  Misses        261      261

Impacted Files	Coverage Δ
src/superspawn.js	69.41% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d6511e...74d1341. Read the comment docs.

[stevengill]

LGTM. Merge it