-
Notifications
You must be signed in to change notification settings - Fork 41
CB-14064: Dependency updates & drop node4 CI #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah, I'm going to get a Windows VM set up to run the tests locally on Windows and see what's going on. I'd really like to not to be stuck on an old version of shelljs :\ |
I got a dual boot setup here, let me take a quick look at it. |
Well basically, So we only need to unwrap the encapsulated string. If I replace the line I linked above with the following, all tests pass on my Windows installation using node 8: cmd = String(shell.which(cmd) || cmd); |
ce87065
to
762c7fe
Compare
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 19 19
Lines 1768 1768
Branches 376 376
=======================================
Hits 1507 1507
Misses 261 261
Continue to review full report at Codecov.
|
762c7fe
to
74d1341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge it
Also added the pull request issue template (copied from cordova-lib) since I noticed that was missing