Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example usage of podspec declarations #67

Merged
merged 1 commit into from Apr 14, 2019

Conversation

@piotr-cz
Copy link
Contributor

commented Apr 3, 2019

Platforms affected

none

Motivation and Context

Complementing docblock for getPodSpecs function

Description

When trying to find more information about new <podspec> tag deprecating <framework type="podspec" /> I found example usage in docblock above getPodSpecs function
However it doesn't specify how to use declarations so I've copied example from specs fixture

Update: Example usage is also described in the docs.

Testing

Change in docblock, no testing required

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary
Add example usage of podspec declarations
When trying to find more information about new `<podspec>` tag deprecating `<framework type="podspec" />` I found this example usage.
However it doesn't specify how to use declarations so I've copied example from [specs fixture](https://github.com/apache/cordova-common/blob/rel/3.1.0/spec/fixtures/plugins/org.test.plugins.withcocoapods/plugin.xml#L37-L47)

@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Apr 3, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 3, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          20       20           
  Lines        1807     1807           
  Branches      370      370           
=======================================
  Hits         1606     1606           
  Misses        201      201
Impacted Files Coverage Δ
src/PluginInfo/PluginInfo.js 83.41% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469e7b4...a78427f. Read the comment docs.

@dpogue

dpogue approved these changes Apr 14, 2019

Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Apr 14, 2019

@dpogue dpogue merged commit 9cd117e into apache:master Apr 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.