Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plist formatting #69

Merged
merged 1 commit into from Jun 11, 2019

Conversation

@oliversalzburg
Copy link
Contributor

commented May 8, 2019

Platforms affected

iOS

Motivation and Context

cordova-ios applies the same formatting already. Neglecting to apply the same here, causes flip-flopping of the file during builds and it's just confusing and inconsistent.

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests May 8, 2019

@oliversalzburg oliversalzburg force-pushed the fairmanager-cordova:fix/plist-formatting branch 5 times, most recently from 796ff71 to 549cbeb May 8, 2019

(ios) Plist document not indented with tabs
Xcode indents .plist documents with tabs, not spaces. Other parts of
Cordova already use tabs for indenting .plist documents and using spaces
directly conflicts with both cases.

@oliversalzburg oliversalzburg force-pushed the fairmanager-cordova:fix/plist-formatting branch from 549cbeb to c19fdff May 8, 2019

Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge May 9, 2019

@dpogue

dpogue approved these changes May 9, 2019

@dpogue dpogue merged commit 8440f18 into apache:master Jun 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Jun 11, 2019

@oliversalzburg oliversalzburg deleted the fairmanager-cordova:fix/plist-formatting branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.