fix: PluginInfoProvider for scoped plugins #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
did you forget to check that file in? :) |
|
@timbru31 Sorry, I messed up during rebasing apparently. The test files are now here too. Thanks for pointing out that they were missing. |
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Oct 24, 2019
breautek
approved these changes
Oct 24, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Motivation and Context
This is the
cordova-commonpart of PRs apache/cordova-lib#602 and apache/cordova-lib#680 whose goal is to support scoped npm packages as plugins the same way as regular packages.Description
The key difference with scoped packages is that they nested within their
@scope/directory in theplugins/directory. This commit changesPluginInfoProviderto honor that fact.Testing
I added an expectation to the unit tests of
PluginInfoProvider.