Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PluginInfoProvider for scoped plugins #94

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

This is the cordova-common part of PRs apache/cordova-lib#602 and apache/cordova-lib#680 whose goal is to support scoped npm packages as plugins the same way as regular packages.

Description

The key difference with scoped packages is that they nested within their @scope/ directory in the plugins/ directory. This commit changes PluginInfoProvider to honor that fact.

Testing

I added an expectation to the unit tests of PluginInfoProvider.

@raphinesse raphinesse added this to the 4.0.0 milestone Oct 24, 2019
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Oct 24, 2019
@timbru31
Copy link
Member

I added an expectation to the unit tests of PluginInfoProvider.

did you forget to check that file in? :)

@raphinesse
Copy link
Contributor Author

@timbru31 Sorry, I messed up during rebasing apparently. The test files are now here too. Thanks for pointing out that they were missing.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Oct 24, 2019
@erisu erisu merged commit d53d266 into apache:master Nov 7, 2019
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Nov 7, 2019
@raphinesse raphinesse deleted the scoped-plugins branch November 7, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

4 participants