Major usability & maintainability improvements #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project-bot
bot
added this to 🐣 New PR / Untriaged
in Apache Cordova: Tooling Pull Requests
erisu
approved these changes
Oct 21, 2019
Apache Cordova: Tooling Pull Requests
automation
moved this from 🐣 New PR / Untriaged
to ✅ Approved, waiting for Merge
Oct 21, 2019
As is the default behavior of npm. When it's finished, we should use apache/cordova-common#34 here. Co-Authored-By: エリス <erisu@users.noreply.github.com>
Apache Cordova: Tooling Pull Requests
automation
moved this from ✅ Approved, waiting for Merge
to 🏆 Merged, waiting for Release
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Motivation and Context
This addresses some long-standing issues (#21, #22, #23, #24, #25, #26) about breaking changes that needed to be made (IMO) to
cordova-create. These changes greatly increase maintainability and usability of the package. They will also allow us to finally implement an easy and robust solution to the problem described in #8.closes: #21
closes: #22
closes: #23
closes: #24
closes: #25
closes: #26
Description
The changes and the rationale behind them are explained in detail in the issues corresponding to each commit.
Testing
I ensured that the automated tests pass. Furthermore, I did a bit of manual testing.