Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major usability & maintainability improvements #40

Merged
merged 7 commits into from Nov 5, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Oct 16, 2019

Motivation and Context

This addresses some long-standing issues (#21, #22, #23, #24, #25, #26) about breaking changes that needed to be made (IMO) to cordova-create. These changes greatly increase maintainability and usability of the package. They will also allow us to finally implement an easy and robust solution to the problem described in #8.

closes: #21
closes: #22
closes: #23
closes: #24
closes: #25
closes: #26

Description

The changes and the rationale behind them are explained in detail in the issues corresponding to each commit.

Testing

I ensured that the automated tests pass. Furthermore, I did a bit of manual testing.

raphinesse added 6 commits Oct 16, 2019
- drop support for using www folders as template
- drop support for www/config.xml
- drop support for improper templates

Fixes apache#25
Fixes apache#24

Also don't create empty platforms & plugins dirs. These will be created
by Cordova when required.
@raphinesse raphinesse requested review from janpio, dpogue, erisu and breautek Oct 16, 2019
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Oct 16, 2019
@raphinesse raphinesse added this to the 3.0.0 milestone Oct 20, 2019
erisu
erisu approved these changes Oct 21, 2019
index.js Outdated Show resolved Hide resolved
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Oct 21, 2019
As is the default behavior of npm.

When it's finished, we should use apache/cordova-common#34 here.

Co-Authored-By: エリス <erisu@users.noreply.github.com>
@erisu erisu merged commit e2223d1 into apache:master Nov 5, 2019
2 checks passed
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Nov 5, 2019
@raphinesse raphinesse deleted the breaking-changes branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment