Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: use platform's common config parser #162

Merged
merged 1 commit into from Aug 3, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 26, 2020

Motivation, Context & Description

There are possibilities that the Cordova-Lib's version of Cordova-Common does not matching the platform's version. There can be cases where the platform introduces supporting logic in common and pins itself to use the new version.

A good example where this case happened in the past was with Adaptive Icons in Cordova Android. Supportive logic was added to common and the platform was pinned but anyone who used the latest platform had issues with adaptive icon because the Lib version of common which was passed to platform and used during prepare was old.

It is expected that platform's common can be updated to a version that lib does not use.

This PR will recreate the common object during prepare with the platform's installed common.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I updated automated test coverage as appropriate for this change

@erisu erisu added this to the 2.0.0 milestone Jul 26, 2020
@erisu erisu requested review from dpogue and breautek July 26, 2020 23:36
@erisu
Copy link
Member Author

erisu commented Aug 3, 2020

Last call. I will be merging this PR in tomorrow.

@erisu erisu merged commit 8c527de into apache:master Aug 3, 2020
@erisu erisu deleted the breaking/use-platform-configparser branch August 3, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant