breaking: use platform's common config parser #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context & Description
There are possibilities that the Cordova-Lib's version of Cordova-Common does not matching the platform's version. There can be cases where the platform introduces supporting logic in common and pins itself to use the new version.
A good example where this case happened in the past was with Adaptive Icons in Cordova Android. Supportive logic was added to common and the platform was pinned but anyone who used the latest platform had issues with adaptive icon because the Lib version of common which was passed to platform and used during prepare was old.
It is expected that platform's common can be updated to a version that lib does not use.
This PR will recreate the common object during prepare with the platform's installed common.
Testing
npm t
Checklist