CB-13503 fix trimID bug when using file:path/to/plugin #13
Conversation
|
|
brodybits
pushed a commit
to brodybits/cordova-fetch
that referenced
this pull request
Aug 6, 2018
when using file:path/to/plugin
This was referenced Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://issues.apache.org/jira/browse/CB-13503
This PR fixes a bug that prevents cordova-fetch from installing plugins when using a local path in package.json, using the syntax :
the syntax without file: works but as the JIRA issue says, the file: prefix is added when running cordova platform add, making subsequent runs fail.
This PR also adds a test case with a dummy plugin that gets installed twice, in order to trigger the problematic call to trimID.