Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13503 fix trimID bug when using file:path/to/plugin #13

Merged
merged 1 commit into from Feb 20, 2018

Conversation

briantobo
Copy link
Contributor

@briantobo briantobo commented Feb 16, 2018

https://issues.apache.org/jira/browse/CB-13503

This PR fixes a bug that prevents cordova-fetch from installing plugins when using a local path in package.json, using the syntax :

"dependencies": {
  "my-plugin": "file:path/to/plugin",
  …
}

the syntax without file: works but as the JIRA issue says, the file: prefix is added when running cordova platform add, making subsequent runs fail.

This PR also adds a test case with a dummy plugin that gets installed twice, in order to trigger the problematic call to trimID.

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@stevengill stevengill merged commit 2932d18 into apache:master Feb 20, 2018
brodybits pushed a commit to brodybits/cordova-fetch that referenced this pull request Aug 6, 2018
when using file:path/to/plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants