Skip to content

Save platforms and plugins to devDependencies#65

Merged
GedasGa merged 1 commit intoapache:masterfrom
GedasGa:install-to-devdeps
Nov 13, 2019
Merged

Save platforms and plugins to devDependencies#65
GedasGa merged 1 commit intoapache:masterfrom
GedasGa:install-to-devdeps

Conversation

@GedasGa
Copy link
Contributor

@GedasGa GedasGa commented Jun 13, 2019

Motivation and Context

Save platforms and plugins to devDependencies and close #64.

Description

For more details please refer to the #64 issue.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this PR.

@erisu
Copy link
Member

erisu commented Oct 31, 2019

@GedasGa, can you rebase and fix the conflicts?

@GedasGa GedasGa force-pushed the install-to-devdeps branch from 511fdfa to b3a1806 Compare November 9, 2019 03:56
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It is good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Save platforms and plugins to devDependencies

4 participants