Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save platforms and plugins to devDependencies #65

Merged
merged 1 commit into from Nov 13, 2019

Conversation

GedasGa
Copy link
Contributor

@GedasGa GedasGa commented Jun 13, 2019

Motivation and Context

Save platforms and plugins to devDependencies and close #64.

Description

For more details please refer to the #64 issue.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Jun 13, 2019
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Jun 13, 2019
Copy link
Contributor

@raphinesse raphinesse left a comment

LGTM. Thanks for this PR.

@erisu
Copy link
Member

@erisu erisu commented Oct 31, 2019

@GedasGa, can you rebase and fix the conflicts?

index.js Show resolved Hide resolved
erisu
erisu approved these changes Nov 11, 2019
Copy link
Member

@erisu erisu left a comment

👍 It is good to go.

@GedasGa GedasGa merged commit 11105d1 into apache:master Nov 13, 2019
2 checks passed
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Nov 13, 2019
@GedasGa GedasGa deleted the install-to-devdeps branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

4 participants