Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save platforms and plugins to devDependencies #65

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Save platforms and plugins to devDependencies #65

merged 1 commit into from
Nov 13, 2019

Conversation

GedasGa
Copy link
Contributor

@GedasGa GedasGa commented Jun 13, 2019

Motivation and Context

Save platforms and plugins to devDependencies and close #64.

Description

For more details please refer to the #64 issue.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@brodycj brodycj mentioned this pull request Jun 13, 2019
Closed
raphinesse
raphinesse approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@raphinesse raphinesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this PR.

@erisu erisu added this to the 3.0.0 milestone Jul 1, 2019
@erisu erisu mentioned this pull request Jul 18, 2019
Closed
@erisu
Copy link
Member

erisu commented Oct 31, 2019

@GedasGa, can you rebase and fix the conflicts?

raphinesse
raphinesse reviewed Nov 10, 2019
View reviewed changes
index.js Show resolved Hide resolved
erisu
erisu approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It is good to go.

@GedasGa GedasGa merged commit 11105d1 into apache:master Nov 13, 2019
@GedasGa GedasGa deleted the install-to-devdeps branch November 13, 2019 06:50
@grunthor grunthor mentioned this pull request May 8, 2020
Closed
3 tasks
@QuentinFarizon QuentinFarizon mentioned this pull request Aug 13, 2021
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphinesse raphinesse raphinesse approved these changes

@breautek breautek breautek left review comments

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Save platforms and plugins to devDependencies
4 participants
@GedasGa @erisu @raphinesse @breautek