Work around npm bug when uninstalling old cordova platforms#78
Merged
erisu merged 1 commit intoapache:masterfrom Oct 31, 2019
Merged
Work around npm bug when uninstalling old cordova platforms#78erisu merged 1 commit intoapache:masterfrom
erisu merged 1 commit intoapache:masterfrom
Conversation
When using `npm@>=6.11.0` on Windows, `npm uninstall` of `cordova-android@5.1.1` will leave an empty folder `node_modules/cordova-android/node_modules` behind. This causes one of our tests to fail but it is very likely an issue with npm. Furthermore this is very unlikely to affect users of `cordova-fetch` in production.
erisu
approved these changes
Oct 31, 2019
Member
erisu
left a comment
erisu
left a comment
There was a problem hiding this comment.
👍 Thank you for looking into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When using
npm@>=6.11.0on Windows,npm uninstallofcordova-android@5.1.1will leave an empty foldernode_modules/cordova-android/node_modulesbehind. This causes one of our tests to fail but it is very likely an issue with npm. Furthermore this is very unlikely to affect users ofcordova-fetchin production.Description
We just install a later version of
cordova-androidandcordova-iosin the test. The exact version or even package installed does not really matter, the test just asserts that a package can be installed and then uninstalled .Testing
CI tests are passing again.