Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around npm bug when uninstalling old cordova platforms #78

Merged
merged 1 commit into from Oct 31, 2019

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Oct 30, 2019

Motivation and Context

When using npm@>=6.11.0 on Windows, npm uninstall of cordova-android@5.1.1 will leave an empty folder node_modules/cordova-android/node_modules behind. This causes one of our tests to fail but it is very likely an issue with npm. Furthermore this is very unlikely to affect users of cordova-fetch in production.

Description

We just install a later version of cordova-android and cordova-ios in the test. The exact version or even package installed does not really matter, the test just asserts that a package can be installed and then uninstalled .

Testing

CI tests are passing again.

When using `npm@>=6.11.0` on Windows, `npm uninstall`
of `cordova-android@5.1.1` will leave an empty folder
`node_modules/cordova-android/node_modules` behind. This causes one of
our tests to fail but it is very likely an issue with npm. Furthermore
this is very unlikely to affect users of `cordova-fetch` in production.
@raphinesse raphinesse added the bug label Oct 30, 2019
@raphinesse raphinesse requested a review from erisu Oct 30, 2019
@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Oct 30, 2019
Apache Cordova: Tooling Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Oct 31, 2019
erisu
erisu approved these changes Oct 31, 2019
Copy link
Member

@erisu erisu left a comment

👍 Thank you for looking into this!

@erisu erisu merged commit 6e78b1a into apache:master Oct 31, 2019
2 checks passed
Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Oct 31, 2019
@raphinesse raphinesse deleted the workaround-npm-bug branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Apache Cordova: Tooling Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

2 participants