Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(versions): DRY version binary code #1185

Merged
merged 1 commit into from Nov 9, 2021

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Nov 7, 2021

Motivation and Context

This removes some minor code smells from the versions module and binaries.

Description

  • all version getters in versions now actually return the version; previously 2 of them logged it directly
  • a common helper method is used to create the legacy version binaries

Testing

  • automated tests pass
  • version binaries still work (checked manually)

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #1185 (14436f6) into master (ea9751b) will decrease coverage by 0.16%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
- Coverage   75.03%   74.86%   -0.17%     
==========================================
  Files          13       13              
  Lines        1650     1655       +5     
==========================================
+ Hits         1238     1239       +1     
- Misses        412      416       +4     
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/versions.js 90.47% <33.33%> (-9.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea9751b...14436f6. Read the comment docs.

@raphinesse raphinesse merged commit d063f44 into apache:master Nov 9, 2021
@raphinesse raphinesse deleted the cleanup-version-bins branch November 9, 2021 06:59
@erisu erisu added this to the 7.0.0 milestone Nov 16, 2021
gazben pushed a commit to apicore-engineering/cordova-ios that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants