Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json cleanup devDependencies #368

Merged
merged 1 commit into from Jun 14, 2018

Conversation

brodybits
Copy link
Contributor

@brodybits brodybits commented Jun 13, 2018

Platforms affected

iOS

What does this PR do?

Removes devDependencies no longer needed from package.json:

  • coffee-script (package name was deprecated in favor of coffeescript)
  • uncrustify

includes plist@3 update proposed in #367

What testing has been done on this change?

  • npm run unit-tests passes
  • starter project from cordova create with iOS platform added by cordova platform add https://github.com/brodybits/cordova-ios#dev-dep-cleanup runs on iOS simulator
  • npm test stages passing on Travis CI in this PR

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   63.99%   63.99%           
=======================================
  Files          14       14           
  Lines        1697     1697           
  Branches      286      286           
=======================================
  Hits         1086     1086           
  Misses        611      611

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e790af...cd4b0b4. Read the comment docs.

@brodybits brodybits changed the title package.json cleanup devDependencies - WIP UNDER TEST package.json cleanup devDependencies Jun 13, 2018
@brodybits
Copy link
Contributor Author

brodybits commented Jun 13, 2018

Updated description

Description is updated as follows:

What does this PR do?

Removes devDependencies no longer needed from package.json:

  • coffee-script (package name was deprecated in favor of coffeescript)
  • uncrustify

includes plist@3 update proposed in #367

What testing has been done on this change?

  • npm run unit-tests passes
  • starter project from cordova create with iOS platform added by cordova platform add https://github.com/brodybits/cordova-ios#dev-dep-cleanup runs on iOS simulator
  • npm test stages passing on Travis CI in this PR

Moving forward

As I said above this PR includes the change I proposed in #367 to update plist to 3.0.x. I would be happy to remove from this PR if needed. proposed change from #367 is now removed from this PR

I also would be happy to squash the commits that remove coffee-script & uncrustify from package.json if needed. proposed changes now squashed

remove packages no longer needed:
- coffee-script (old package name, was deprecated
  in favor of coffeescript)
- uncrustify
@brodybits brodybits merged commit fdd12a1 into apache:master Jun 14, 2018
@brodybits brodybits deleted the dev-dep-cleanup branch June 14, 2018 03:14
@brodybits
Copy link
Contributor Author

Squashed, rebased without plist@3 update (#367), and merged in fdd12a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants